From: Abhijit Halder <abhijit.k.halder@gmail.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PING] Bad Indentation in remote.c: Someone please correct this.
Date: Wed, 07 Sep 2011 10:44:00 -0000 [thread overview]
Message-ID: <CAOhZP9zPLYYfeRB-GL9k2Cd_=LYZM3=x6G9wJnEYDK05FNVGcw@mail.gmail.com> (raw)
In-Reply-To: <201109071135.14630.pedro@codesourcery.com>
On Wed, Sep 7, 2011 at 4:05 PM, Pedro Alves <pedro@codesourcery.com> wrote:
> On Wednesday 07 September 2011 11:02:35, Abhijit Halder wrote:
>> On Wed, Sep 7, 2011 at 3:23 PM, Pedro Alves <pedro@codesourcery.com> wrote:
>> > On Wednesday 07 September 2011 10:32:51, Abhijit Halder wrote:
>> >
>> >> #cvs diff gdb/remote.c
>> >>
>> >> Index: gdb/remote.c
>> >> ===================================================================
>> >> RCS file: /cvs/src/src/gdb/remote.c,v
>> >> retrieving revision 1.461
>> >> diff -r1.461 remote.c
>> >> 4883c4883
>> >> < }
>> >> ---
>> >> > }
>> >
>> > plain diff output is unreadable by mere mortals. Use "cvs diff -up".
>> >
>> > --
>> > Pedro Alves
>> >
>>
>> Okay. Here it is:
>>
>
> Applied, thanks. Please send a ChangeLog entry next time.
>
> --
> Pedro Alves
>
> 2011-09-07 Abhijit Halder <abhijit.k.halder@gmail.com>
>
> * remote.c (remote_console_output): Reindent.
>
> ---
> gdb/remote.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: src/gdb/remote.c
> ===================================================================
> --- src.orig/gdb/remote.c 2011-08-26 12:58:48.000000000 +0100
> +++ src/gdb/remote.c 2011-09-07 11:29:14.357975075 +0100
> @@ -4879,8 +4879,8 @@ remote_console_output (char *msg)
> tb[1] = 0;
> fputs_unfiltered (tb, gdb_stdtarg);
> }
> - gdb_flush (gdb_stdtarg);
> - }
> + gdb_flush (gdb_stdtarg);
> +}
>
> typedef struct cached_reg
> {
>
Sure.
Thanks,
Abhijit Halder
prev parent reply other threads:[~2011-09-07 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-07 9:44 Abhijit Halder
2011-09-07 9:46 ` Abhijit Halder
2011-09-07 9:59 ` Pedro Alves
2011-09-07 10:08 ` Abhijit Halder
2011-09-07 10:38 ` Pedro Alves
2011-09-07 10:44 ` Abhijit Halder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOhZP9zPLYYfeRB-GL9k2Cd_=LYZM3=x6G9wJnEYDK05FNVGcw@mail.gmail.com' \
--to=abhijit.k.halder@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox