From: Hui Zhu <teawater@gmail.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
Date: Sun, 22 Jul 2012 10:11:00 -0000 [thread overview]
Message-ID: <CANFwon3NaJuSkia68LvPjW=zuYYrcMOP_H3kVx0--becGnnc2Q@mail.gmail.com> (raw)
In-Reply-To: <CANFwon2VuRFfxyBdr2ndfyxi_fXsRih=DN2MWGh8xX7dUWCtbg@mail.gmail.com>
On Sun, Jul 22, 2012 at 4:55 PM, Hui Zhu <teawater@gmail.com> wrote:
> On Sun, Jul 22, 2012 at 3:10 PM, Jan Kratochvil
> <jan.kratochvil@redhat.com> wrote:
>> On Sun, 22 Jul 2012 08:30:02 +0200, Hui Zhu wrote:
>>> This issue is because function linespec_lexer_lex_one handle the
>>> string that begin with decimal numbers decimal numbers directly and
>>> use linespec_lexer_lex_number handle it directly.
>>
>> There should be a testcase for it. (Not a review yet.)
>>
>>
>> Thanks,
>> Jan
>
> Agree. I will add it later.
>
> Thanks,
> Hui
Hi,
I got a trouble with test.
This issue must build test code without dir, for example: "1.c".
But "gdb_compile" or "prepare_for_testing" will build the test code
with dir, for example:"src/gdb/testsuite/gdb.base/1.c".
Could you tell me how to handle it?
Thanks,
Hui
next prev parent reply other threads:[~2012-07-22 10:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 6:30 Hui Zhu
2012-07-22 7:11 ` Jan Kratochvil
2012-07-22 8:55 ` Hui Zhu
2012-07-22 10:11 ` Hui Zhu [this message]
2012-07-22 10:52 ` Jan Kratochvil
2012-07-23 14:26 ` Tom Tromey
2012-07-23 18:04 ` Keith Seitz
2012-07-22 14:12 ` Keith Seitz
2012-07-22 14:48 ` Hui Zhu
2012-07-23 14:28 ` Tom Tromey
2012-07-23 17:17 ` Keith Seitz
2012-07-24 3:48 ` Hui Zhu
2012-07-24 19:36 ` Tom Tromey
2012-07-25 12:57 ` Hui Zhu
2012-07-25 21:21 ` Keith Seitz
2012-07-26 13:52 ` Tom Tromey
2012-07-26 18:21 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANFwon3NaJuSkia68LvPjW=zuYYrcMOP_H3kVx0--becGnnc2Q@mail.gmail.com' \
--to=teawater@gmail.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox