From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Keith Seitz <keiths@redhat.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
Date: Mon, 23 Jul 2012 14:28:00 -0000 [thread overview]
Message-ID: <87k3xusgan.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CANFwon2u=xV4XqKV33Fqk_1k7QQQWixMDNNjJKM01tkV4dTWxQ@mail.gmail.com> (Hui Zhu's message of "Sun, 22 Jul 2012 22:47:11 +0800")
>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
>> The string begin with a number is not a error, why handle it as a
>> error? I think that will really make this part obfuscates.
>> What I thought is change the function name to
>> linespec_lexer_lex_number_string to make it clear.
How about changing linespec_lexer_lex_number to return a boolean
indicating whether it succeeded? This is basically the same idea, but
without introducing a new token.
Tom
next prev parent reply other threads:[~2012-07-23 14:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-22 6:30 Hui Zhu
2012-07-22 7:11 ` Jan Kratochvil
2012-07-22 8:55 ` Hui Zhu
2012-07-22 10:11 ` Hui Zhu
2012-07-22 10:52 ` Jan Kratochvil
2012-07-23 14:26 ` Tom Tromey
2012-07-23 18:04 ` Keith Seitz
2012-07-22 14:12 ` Keith Seitz
2012-07-22 14:48 ` Hui Zhu
2012-07-23 14:28 ` Tom Tromey [this message]
2012-07-23 17:17 ` Keith Seitz
2012-07-24 3:48 ` Hui Zhu
2012-07-24 19:36 ` Tom Tromey
2012-07-25 12:57 ` Hui Zhu
2012-07-25 21:21 ` Keith Seitz
2012-07-26 13:52 ` Tom Tromey
2012-07-26 18:21 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3xusgan.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox