From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-92988-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3438 invoked by alias); 23 Jul 2012 14:28:35 -0000
Received: (qmail 3430 invoked by uid 22791); 23 Jul 2012 14:28:34 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Jul 2012 14:28:19 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6NESIAN022555	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 23 Jul 2012 10:28:18 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6NESH5e004541	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 23 Jul 2012 10:28:17 -0400
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Keith Seitz <keiths@redhat.com>,        gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
References: <CANFwon22Tt57WcsDE8rPrSjgxg62MbgsN0WrAELu9Y52RDwUGg@mail.gmail.com>	<500C0A1F.8040106@redhat.com>	<CANFwon2u=xV4XqKV33Fqk_1k7QQQWixMDNNjJKM01tkV4dTWxQ@mail.gmail.com>
Date: Mon, 23 Jul 2012 14:28:00 -0000
In-Reply-To: <CANFwon2u=xV4XqKV33Fqk_1k7QQQWixMDNNjJKM01tkV4dTWxQ@mail.gmail.com>	(Hui Zhu's message of "Sun, 22 Jul 2012 22:47:11 +0800")
Message-ID: <87k3xusgan.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00444.txt.bz2

>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:

>> The string begin with a number is not a error, why handle it as a
>> error?  I think that will really make this part obfuscates.
>> What I thought is change the function name to
>> linespec_lexer_lex_number_string to make it clear.

How about changing linespec_lexer_lex_number to return a boolean
indicating whether it succeeded?  This is basically the same idea, but
without introducing a new token.

Tom