Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Hui Zhu <teawater@gmail.com>,
	gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
Date: Mon, 23 Jul 2012 18:04:00 -0000	[thread overview]
Message-ID: <500D9238.8010004@redhat.com> (raw)
In-Reply-To: <87obn6sge3.fsf@fleche.redhat.com>

On 07/23/2012 07:26 AM, Tom Tromey wrote:
>>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
>
>>> This issue must build test code without dir, for example: "1.c".
>
> Why is that?
> It seems to me that the problem is in the linespec lexer, and that
> "break 1.c:5" or whatever ought to work ok.

It should also be pretty trivial to add a test for this case, too:

--- a/gdb/testsuite/gdb.linespec/ls-errs.exp
+++ b/gdb/testsuite/gdb.linespec/ls-errs.exp
@@ -124,7 +124,8 @@ foreach x [list "this_file_doesn't_exist.c" \
                "'this 'file' has quotes.c'" \
                "\"this 'file' has quotes.c\"" \
                "\"spaces: and :colons.c\"" \
-              "'more: :spaces: :and  colons::.c'"] {
+              "'more: :spaces: :and  colons::.c'" \
+              "1.c"] {
      # Remove any quoting from FILENAME for the error message.
      add the_tests "$x:3" invalid_file [string trim $x \"']
  }


Keith


  reply	other threads:[~2012-07-23 18:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-22  6:30 Hui Zhu
2012-07-22  7:11 ` Jan Kratochvil
2012-07-22  8:55   ` Hui Zhu
2012-07-22 10:11     ` Hui Zhu
2012-07-22 10:52       ` Jan Kratochvil
2012-07-23 14:26       ` Tom Tromey
2012-07-23 18:04         ` Keith Seitz [this message]
2012-07-22 14:12 ` Keith Seitz
2012-07-22 14:48   ` Hui Zhu
2012-07-23 14:28     ` Tom Tromey
2012-07-23 17:17       ` Keith Seitz
2012-07-24  3:48       ` Hui Zhu
2012-07-24 19:36         ` Tom Tromey
2012-07-25 12:57           ` Hui Zhu
2012-07-25 21:21             ` Keith Seitz
2012-07-26 13:52               ` Tom Tromey
2012-07-26 18:21                 ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=500D9238.8010004@redhat.com \
    --to=keiths@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=teawater@gmail.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox