Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Hui Zhu <teawater@gmail.com>
To: gdb-patches ml <gdb-patches@sourceware.org>
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers
Date: Sun, 22 Jul 2012 06:30:00 -0000	[thread overview]
Message-ID: <CANFwon22Tt57WcsDE8rPrSjgxg62MbgsN0WrAELu9Y52RDwUGg@mail.gmail.com> (raw)

Hi,

This issue is because function linespec_lexer_lex_one handle the
string that begin with decimal numbers decimal numbers directly and
use linespec_lexer_lex_number handle it directly.
So when there are a file name that begin with decimal numbers, will a
lot of error around it.

I post a patch make linespec_lexer_lex_number if number followed by
non-space string, use linespec_lexer_lex_string handle linespec as a
string.

Joel, this issue affect 7.5.  Does this patch can add to 7.5 branch?

Thanks,
Hui

2012-07-22  Hui Zhu  <hui_zhu@mentor.com>

	* linespec.c (linespec_lexer_lex_number): Call
	linespec_lexer_lex_string if the number is followed by
	non-space string.

---
 linespec.c |    8 ++++++++
 1 file changed, 8 insertions(+)

--- a/linespec.c
+++ b/linespec.c
@@ -368,6 +368,8 @@ static const char *const linespec_quote_
 /* Lex a number from the input in PARSER.  This only supports
    decimal numbers.  */

+static linespec_token linespec_lexer_lex_string (linespec_parser *parser);
+
 static linespec_token
 linespec_lexer_lex_number (linespec_parser *parser)
 {
@@ -390,6 +392,12 @@ linespec_lexer_lex_number (linespec_pars
       ++(PARSER_STREAM (parser));
     }

+  if (*PARSER_STREAM (parser) != '\0' && !isspace(*PARSER_STREAM (parser)))
+    {
+      PARSER_STREAM (parser) = LS_TOKEN_STOKEN (token).ptr;
+      return linespec_lexer_lex_string (parser);
+    }
+
   return token;
 }


             reply	other threads:[~2012-07-22  6:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-22  6:30 Hui Zhu [this message]
2012-07-22  7:11 ` Jan Kratochvil
2012-07-22  8:55   ` Hui Zhu
2012-07-22 10:11     ` Hui Zhu
2012-07-22 10:52       ` Jan Kratochvil
2012-07-23 14:26       ` Tom Tromey
2012-07-23 18:04         ` Keith Seitz
2012-07-22 14:12 ` Keith Seitz
2012-07-22 14:48   ` Hui Zhu
2012-07-23 14:28     ` Tom Tromey
2012-07-23 17:17       ` Keith Seitz
2012-07-24  3:48       ` Hui Zhu
2012-07-24 19:36         ` Tom Tromey
2012-07-25 12:57           ` Hui Zhu
2012-07-25 21:21             ` Keith Seitz
2012-07-26 13:52               ` Tom Tromey
2012-07-26 18:21                 ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANFwon22Tt57WcsDE8rPrSjgxg62MbgsN0WrAELu9Y52RDwUGg@mail.gmail.com \
    --to=teawater@gmail.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox