From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18945 invoked by alias); 22 Jul 2012 10:11:40 -0000 Received: (qmail 18936 invoked by uid 22791); 22 Jul 2012 10:11:39 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-ob0-f169.google.com (HELO mail-ob0-f169.google.com) (209.85.214.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 22 Jul 2012 10:11:26 +0000 Received: by obhx4 with SMTP id x4so9640160obh.0 for ; Sun, 22 Jul 2012 03:11:26 -0700 (PDT) Received: by 10.50.242.73 with SMTP id wo9mr8217906igc.1.1342951886080; Sun, 22 Jul 2012 03:11:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.146.205 with HTTP; Sun, 22 Jul 2012 03:10:45 -0700 (PDT) In-Reply-To: References: <20120722071044.GA8522@host2.jankratochvil.net> From: Hui Zhu Date: Sun, 22 Jul 2012 10:11:00 -0000 Message-ID: Subject: Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers To: Jan Kratochvil Cc: gdb-patches ml , Joel Brobecker Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00425.txt.bz2 On Sun, Jul 22, 2012 at 4:55 PM, Hui Zhu wrote: > On Sun, Jul 22, 2012 at 3:10 PM, Jan Kratochvil > wrote: >> On Sun, 22 Jul 2012 08:30:02 +0200, Hui Zhu wrote: >>> This issue is because function linespec_lexer_lex_one handle the >>> string that begin with decimal numbers decimal numbers directly and >>> use linespec_lexer_lex_number handle it directly. >> >> There should be a testcase for it. (Not a review yet.) >> >> >> Thanks, >> Jan > > Agree. I will add it later. > > Thanks, > Hui Hi, I got a trouble with test. This issue must build test code without dir, for example: "1.c". But "gdb_compile" or "prepare_for_testing" will build the test code with dir, for example:"src/gdb/testsuite/gdb.base/1.c". Could you tell me how to handle it? Thanks, Hui