PATCH: Check gdbarch_ptr_bit for x32 core dump

PATCH: Check gdbarch_ptr_bit for x32 core dump

[H.J. Lu]

Hi,

This patch checks gdbarch_ptr_bit for x32 core dump.  Tested on
Linux/x86-64.  Ok to install?

Thanks.

H.J.
---
	* amd64-linux-tdep.c (amd64_linux_core_read_description): Check
	gdbarch_ptr_bit for x32 core dump.

diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c
index acc7303..601ce20 100644
--- a/gdb/amd64-linux-tdep.c
+++ b/gdb/amd64-linux-tdep.c
@@ -1273,9 +1290,15 @@ amd64_linux_core_read_description (struct gdbarch *gdbarch,
   switch ((xcr0 & I386_XSTATE_AVX_MASK))
     {
     case I386_XSTATE_AVX_MASK:
-      return tdesc_amd64_avx_linux;
+      if (gdbarch_ptr_bit (gdbarch) == 32)
+	return tdesc_x32_avx_linux;
+      else
+	return tdesc_amd64_avx_linux;
     default:
-      return tdesc_amd64_linux;
+      if (gdbarch_ptr_bit (gdbarch) == 32)
+	return tdesc_x32_linux;
+      else
+	return tdesc_amd64_linux;
     }
 }
 

Re: PATCH: Check gdbarch_ptr_bit for x32 core dump

[Mark Kettenis]

> Date: Fri, 11 May 2012 12:33:36 -0700
> From: "H.J. Lu" <hongjiu.lu@intel.com>
> 
> Hi,
> 
> This patch checks gdbarch_ptr_bit for x32 core dump.  Tested on
> Linux/x86-64.  Ok to install?

This is ok once the diff to add tde definitions for tdesc_x32_linux
and tdesc_x32_avx_linux to amd64-linux-tdep.h is in.

> 
> Thanks.
> 
> H.J.
> ---
> 	* amd64-linux-tdep.c (amd64_linux_core_read_description): Check
> 	gdbarch_ptr_bit for x32 core dump.

Re: PATCH: Check gdbarch_ptr_bit for x32 core dump

[H.J. Lu]

On Fri, May 11, 2012 at 1:29 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>> Date: Fri, 11 May 2012 12:33:36 -0700
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>>
>> Hi,
>>
>> This patch checks gdbarch_ptr_bit for x32 core dump.  Tested on
>> Linux/x86-64.  Ok to install?
>
> This is ok once the diff to add tde definitions for tdesc_x32_linux
> and tdesc_x32_avx_linux to amd64-linux-tdep.h is in.
>

This won't work since desc_x32_linux and tdesc_x32_avx_linux are
defined by

diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c
index acc7303..601ce20 100644
--- a/gdb/amd64-linux-tdep.c
+++ b/gdb/amd64-linux-tdep.c
@@ -42,6 +42,8 @@

 #include "features/i386/amd64-linux.c"
 #include "features/i386/amd64-avx-linux.c"
+#include "features/i386/x32-linux.c"
+#include "features/i386/x32-avx-linux.c"

in

http://sourceware.org/ml/gdb-patches/2012-05/msg00437.html

Can I apply the above change together with the additional change in
amd64-linux-tdep.h?

Thanks.


-- 
H.J.

Re: PATCH: Check gdbarch_ptr_bit for x32 core dump

[Mark Kettenis]

> Date: Fri, 11 May 2012 14:00:47 -0700
> From: "H.J. Lu" <hjl.tools@gmail.com>
>
> > This is ok once the diff to add tde definitions for tdesc_x32_linux
> > and tdesc_x32_avx_linux to amd64-linux-tdep.h is in.
> >
> 
> This won't work since desc_x32_linux and tdesc_x32_avx_linux are
> defined by
> 
> diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c
> index acc7303..601ce20 100644
> --- a/gdb/amd64-linux-tdep.c
> +++ b/gdb/amd64-linux-tdep.c
> @@ -42,6 +42,8 @@
> 
>  #include "features/i386/amd64-linux.c"
>  #include "features/i386/amd64-avx-linux.c"
> +#include "features/i386/x32-linux.c"
> +#include "features/i386/x32-avx-linux.c"
> 
> in
> 
> http://sourceware.org/ml/gdb-patches/2012-05/msg00437.html
> 
> Can I apply the above change together with the additional change in
> amd64-linux-tdep.h?

You mean just adding those includes?  Yes that's fine.