From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29275 invoked by alias); 11 May 2012 22:12:44 -0000 Received: (qmail 29265 invoked by uid 22791); 11 May 2012 22:12:43 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,TW_AV,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 May 2012 22:12:30 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id q4BMCRTX019638; Sat, 12 May 2012 00:12:27 +0200 (CEST) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id q4BMCQJg027917; Sat, 12 May 2012 00:12:26 +0200 (CEST) Date: Fri, 11 May 2012 22:12:00 -0000 Message-Id: <201205112212.q4BMCQJg027917@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: hjl.tools@gmail.com CC: gdb-patches@sourceware.org In-reply-to: (hjl.tools@gmail.com) Subject: Re: PATCH: Check gdbarch_ptr_bit for x32 core dump References: <20120511193336.GA5134@intel.com> <201205112029.q4BKTkAK010160@glazunov.sibelius.xs4all.nl> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00459.txt.bz2 > Date: Fri, 11 May 2012 14:00:47 -0700 > From: "H.J. Lu" > > > This is ok once the diff to add tde definitions for tdesc_x32_linux > > and tdesc_x32_avx_linux to amd64-linux-tdep.h is in. > > > > This won't work since desc_x32_linux and tdesc_x32_avx_linux are > defined by > > diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c > index acc7303..601ce20 100644 > --- a/gdb/amd64-linux-tdep.c > +++ b/gdb/amd64-linux-tdep.c > @@ -42,6 +42,8 @@ > > #include "features/i386/amd64-linux.c" > #include "features/i386/amd64-avx-linux.c" > +#include "features/i386/x32-linux.c" > +#include "features/i386/x32-avx-linux.c" > > in > > http://sourceware.org/ml/gdb-patches/2012-05/msg00437.html > > Can I apply the above change together with the additional change in > amd64-linux-tdep.h? You mean just adding those includes? Yes that's fine.