From: "H.J. Lu" <hjl.tools@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: PATCH: Check gdbarch_ptr_bit for x32 core dump
Date: Fri, 11 May 2012 21:01:00 -0000 [thread overview]
Message-ID: <CAMe9rOr3_qgLJOUvfQoJ_ooSMpmyu6gY-d7CHX2Ps36ekZXv3Q@mail.gmail.com> (raw)
In-Reply-To: <201205112029.q4BKTkAK010160@glazunov.sibelius.xs4all.nl>
On Fri, May 11, 2012 at 1:29 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wrote:
>> Date: Fri, 11 May 2012 12:33:36 -0700
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>>
>> Hi,
>>
>> This patch checks gdbarch_ptr_bit for x32 core dump. Tested on
>> Linux/x86-64. Ok to install?
>
> This is ok once the diff to add tde definitions for tdesc_x32_linux
> and tdesc_x32_avx_linux to amd64-linux-tdep.h is in.
>
This won't work since desc_x32_linux and tdesc_x32_avx_linux are
defined by
diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c
index acc7303..601ce20 100644
--- a/gdb/amd64-linux-tdep.c
+++ b/gdb/amd64-linux-tdep.c
@@ -42,6 +42,8 @@
#include "features/i386/amd64-linux.c"
#include "features/i386/amd64-avx-linux.c"
+#include "features/i386/x32-linux.c"
+#include "features/i386/x32-avx-linux.c"
in
http://sourceware.org/ml/gdb-patches/2012-05/msg00437.html
Can I apply the above change together with the additional change in
amd64-linux-tdep.h?
Thanks.
--
H.J.
next prev parent reply other threads:[~2012-05-11 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 19:33 H.J. Lu
2012-05-11 20:30 ` Mark Kettenis
2012-05-11 21:01 ` H.J. Lu [this message]
2012-05-11 22:12 ` Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMe9rOr3_qgLJOUvfQoJ_ooSMpmyu6gY-d7CHX2Ps36ekZXv3Q@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox