From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-91015-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4379 invoked by alias); 11 May 2012 21:01:06 -0000
Received: (qmail 4369 invoked by uid 22791); 11 May 2012 21:01:05 -0000
X-SWARE-Spam-Status: No, hits=-4.9 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,TW_AV
X-Spam-Check-By: sourceware.org
Received: from mail-qa0-f48.google.com (HELO mail-qa0-f48.google.com) (209.85.216.48)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 May 2012 21:00:48 +0000
Received: by qady23 with SMTP id y23so2199099qad.14        for <gdb-patches@sourceware.org>; Fri, 11 May 2012 14:00:48 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.229.137.18 with SMTP id u18mr4941937qct.87.1336770047933; Fri, 11 May 2012 14:00:47 -0700 (PDT)
Received: by 10.229.169.130 with HTTP; Fri, 11 May 2012 14:00:47 -0700 (PDT)
In-Reply-To: <201205112029.q4BKTkAK010160@glazunov.sibelius.xs4all.nl>
References: <20120511193336.GA5134@intel.com>	<201205112029.q4BKTkAK010160@glazunov.sibelius.xs4all.nl>
Date: Fri, 11 May 2012 21:01:00 -0000
Message-ID: <CAMe9rOr3_qgLJOUvfQoJ_ooSMpmyu6gY-d7CHX2Ps36ekZXv3Q@mail.gmail.com>
Subject: Re: PATCH: Check gdbarch_ptr_bit for x32 core dump
From: "H.J. Lu" <hjl.tools@gmail.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-05/txt/msg00457.txt.bz2

On Fri, May 11, 2012 at 1:29 PM, Mark Kettenis <mark.kettenis@xs4all.nl> wr=
ote:
>> Date: Fri, 11 May 2012 12:33:36 -0700
>> From: "H.J. Lu" <hongjiu.lu@intel.com>
>>
>> Hi,
>>
>> This patch checks gdbarch_ptr_bit for x32 core dump. =A0Tested on
>> Linux/x86-64. =A0Ok to install?
>
> This is ok once the diff to add tde definitions for tdesc_x32_linux
> and tdesc_x32_avx_linux to amd64-linux-tdep.h is in.
>

This won't work since desc_x32_linux and tdesc_x32_avx_linux are
defined by

diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c
index acc7303..601ce20 100644
--- a/gdb/amd64-linux-tdep.c
+++ b/gdb/amd64-linux-tdep.c
@@ -42,6 +42,8 @@

 #include "features/i386/amd64-linux.c"
 #include "features/i386/amd64-avx-linux.c"
+#include "features/i386/x32-linux.c"
+#include "features/i386/x32-avx-linux.c"

in

http://sourceware.org/ml/gdb-patches/2012-05/msg00437.html

Can I apply the above change together with the additional change in
amd64-linux-tdep.h?

Thanks.


--=20
H.J.