Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* mips-rtems4.11 sim undefined error
@ 2012-09-04 16:58 Joel Sherrill
  2012-09-04 19:09 ` Mike Frysinger
  0 siblings, 1 reply; 5+ messages in thread
From: Joel Sherrill @ 2012-09-04 16:58 UTC (permalink / raw)
  To: gdb-patches

Hi

Configuring for mips-rtems4.11 (not tx39) with the simulator
enabled on the svn head gave me this error linking "run":

libsim.a(interp.o): In function `sim_open':
/home/joel/v850/tools/b-gdb-cvs-src/sim/mips/../../../gdb-cvs/src/sim/mips/interp.c:551: 
undefined reference to `sockser_addr'

Is this OK to apply?

2012-09-03  Joel Sherrill <joel.sherrill@oarcorp.com>

     * configure.ac: Link against dv-sockser.o
     * configure: Regenerate.

Index: configure.ac
===================================================================
RCS file: /cvs/src/src/sim/mips/configure.ac,v
retrieving revision 1.18
diff -u -r1.18 configure.ac
--- configure.ac    4 Jan 2012 08:28:20 -0000    1.18
+++ configure.ac    4 Sep 2012 15:45:13 -0000
@@ -413,7 +413,7 @@
      SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
      ;;
    *)
-    mips_extra_objs=""
+    mips_extra_objs="dv-sockser.o"
      ;;
  esac
  SIM_AC_OPTION_HARDWARE($hw_enabled,$hw_devices,$hw_extra_devices)

-- 
Joel Sherrill, Ph.D.             Director of Research&   Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
     Support Available             (256) 722-9985



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: mips-rtems4.11 sim undefined error
  2012-09-04 16:58 mips-rtems4.11 sim undefined error Joel Sherrill
@ 2012-09-04 19:09 ` Mike Frysinger
  2012-09-04 20:16   ` Joel Sherrill
  0 siblings, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2012-09-04 19:09 UTC (permalink / raw)
  To: Joel Sherrill; +Cc: gdb-patches

On Tue, Sep 4, 2012 at 12:57 PM, Joel Sherrill wrote:
> --- configure.ac    4 Jan 2012 08:28:20 -0000    1.18
> +++ configure.ac    4 Sep 2012 15:45:13 -0000
> @@ -413,7 +413,7 @@
>      SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
>      ;;
>    *)
> -    mips_extra_objs=""
> +    mips_extra_objs="dv-sockser.o"
>      ;;
>  esac

considering mips_extra_objs is now the same value for all targets, i
would pull it out of the case statement and move it down below
-mike


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: mips-rtems4.11 sim undefined error
  2012-09-04 19:09 ` Mike Frysinger
@ 2012-09-04 20:16   ` Joel Sherrill
  2012-09-04 21:10     ` Mike Frysinger
  0 siblings, 1 reply; 5+ messages in thread
From: Joel Sherrill @ 2012-09-04 20:16 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: gdb-patches

On 09/04/2012 02:09 PM, Mike Frysinger wrote:
> On Tue, Sep 4, 2012 at 12:57 PM, Joel Sherrill wrote:
>> --- configure.ac    4 Jan 2012 08:28:20 -0000    1.18
>> +++ configure.ac    4 Sep 2012 15:45:13 -0000
>> @@ -413,7 +413,7 @@
>>       SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
>>       ;;
>>     *)
>> -    mips_extra_objs=""
>> +    mips_extra_objs="dv-sockser.o"
>>       ;;
>>   esac
> considering mips_extra_objs is now the same value for all targets, i
> would pull it out of the case statement and move it down below
>
How about this?

Index: configure.ac
===================================================================
RCS file: /cvs/src/src/sim/mips/configure.ac,v
retrieving revision 1.18
diff -u -r1.18 configure.ac
--- configure.ac    4 Jan 2012 08:28:20 -0000    1.18
+++ configure.ac    4 Sep 2012 20:15:37 -0000
@@ -409,13 +409,12 @@
    mips*tx39*)
      hw_enabled=yes
      hw_extra_devices="tx3904cpu tx3904irc tx3904tmr tx3904sio"
-    mips_extra_objs="dv-sockser.o"
      SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
      ;;
    *)
-    mips_extra_objs=""
      ;;
  esac
+mips_extra_objs="dv-sockser.o"
  SIM_AC_OPTION_HARDWARE($hw_enabled,$hw_devices,$hw_extra_devices)
  AC_SUBST(mips_extra_objs)

> -mike


-- 
Joel Sherrill, Ph.D.             Director of Research&   Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
     Support Available             (256) 722-9985



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: mips-rtems4.11 sim undefined error
  2012-09-04 20:16   ` Joel Sherrill
@ 2012-09-04 21:10     ` Mike Frysinger
  2012-09-04 21:41       ` Joel Sherrill
  0 siblings, 1 reply; 5+ messages in thread
From: Mike Frysinger @ 2012-09-04 21:10 UTC (permalink / raw)
  To: Joel Sherrill; +Cc: gdb-patches

On Tue, Sep 4, 2012 at 4:16 PM, Joel Sherrill wrote:
> On 09/04/2012 02:09 PM, Mike Frysinger wrote:
>> On Tue, Sep 4, 2012 at 12:57 PM, Joel Sherrill wrote:
>>>
>>> --- configure.ac    4 Jan 2012 08:28:20 -0000    1.18
>>> +++ configure.ac    4 Sep 2012 15:45:13 -0000
>>> @@ -413,7 +413,7 @@
>>>       SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
>>>       ;;
>>>     *)
>>> -    mips_extra_objs=""
>>> +    mips_extra_objs="dv-sockser.o"
>>>       ;;
>>>   esac
>>
>> considering mips_extra_objs is now the same value for all targets, i
>> would pull it out of the case statement and move it down below
>>
> How about this?
>
>
> Index: configure.ac
> ===================================================================
> RCS file: /cvs/src/src/sim/mips/configure.ac,v
> retrieving revision 1.18
> diff -u -r1.18 configure.ac
> --- configure.ac    4 Jan 2012 08:28:20 -0000    1.18
> +++ configure.ac    4 Sep 2012 20:15:37 -0000
> @@ -409,13 +409,12 @@
>    mips*tx39*)
>      hw_enabled=yes
>      hw_extra_devices="tx3904cpu tx3904irc tx3904tmr tx3904sio"
> -    mips_extra_objs="dv-sockser.o"
>
>      SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
>      ;;
>    *)
> -    mips_extra_objs=""
>      ;;
>  esac
> +mips_extra_objs="dv-sockser.o"
>  SIM_AC_OPTION_HARDWARE($hw_enabled,$hw_devices,$hw_extra_devices)
>  AC_SUBST(mips_extra_objs)

i'd move it down one line more to just above AC_SUBST :)

feel free to commit w/that minor tweak
-mike


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: mips-rtems4.11 sim undefined error
  2012-09-04 21:10     ` Mike Frysinger
@ 2012-09-04 21:41       ` Joel Sherrill
  0 siblings, 0 replies; 5+ messages in thread
From: Joel Sherrill @ 2012-09-04 21:41 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: gdb-patches

On 09/04/2012 04:10 PM, Mike Frysinger wrote:
> On Tue, Sep 4, 2012 at 4:16 PM, Joel Sherrill wrote:
>> On 09/04/2012 02:09 PM, Mike Frysinger wrote:
>>> On Tue, Sep 4, 2012 at 12:57 PM, Joel Sherrill wrote:
>>>> --- configure.ac    4 Jan 2012 08:28:20 -0000    1.18
>>>> +++ configure.ac    4 Sep 2012 15:45:13 -0000
>>>> @@ -413,7 +413,7 @@
>>>>        SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
>>>>        ;;
>>>>      *)
>>>> -    mips_extra_objs=""
>>>> +    mips_extra_objs="dv-sockser.o"
>>>>        ;;
>>>>    esac
>>> considering mips_extra_objs is now the same value for all targets, i
>>> would pull it out of the case statement and move it down below
>>>
>> How about this?
>>
>>
>> Index: configure.ac
>> ===================================================================
>> RCS file: /cvs/src/src/sim/mips/configure.ac,v
>> retrieving revision 1.18
>> diff -u -r1.18 configure.ac
>> --- configure.ac    4 Jan 2012 08:28:20 -0000    1.18
>> +++ configure.ac    4 Sep 2012 20:15:37 -0000
>> @@ -409,13 +409,12 @@
>>     mips*tx39*)
>>       hw_enabled=yes
>>       hw_extra_devices="tx3904cpu tx3904irc tx3904tmr tx3904sio"
>> -    mips_extra_objs="dv-sockser.o"
>>
>>       SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
>>       ;;
>>     *)
>> -    mips_extra_objs=""
>>       ;;
>>   esac
>> +mips_extra_objs="dv-sockser.o"
>>   SIM_AC_OPTION_HARDWARE($hw_enabled,$hw_devices,$hw_extra_devices)
>>   AC_SUBST(mips_extra_objs)
> i'd move it down one line more to just above AC_SUBST :)
>
> feel free to commit w/that minor tweak
Committed. I hope it is is exactly the right place.

Thanks. :)
> -mike


-- 
Joel Sherrill, Ph.D.             Director of Research&   Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
     Support Available             (256) 722-9985



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-09-04 21:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-04 16:58 mips-rtems4.11 sim undefined error Joel Sherrill
2012-09-04 19:09 ` Mike Frysinger
2012-09-04 20:16   ` Joel Sherrill
2012-09-04 21:10     ` Mike Frysinger
2012-09-04 21:41       ` Joel Sherrill

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox