From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94312-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 7273 invoked by alias); 4 Sep 2012 21:10:48 -0000
Received: (qmail 7230 invoked by uid 22791); 4 Sep 2012 21:10:46 -0000
X-SWARE-Spam-Status: No, hits=-5.0 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE
X-Spam-Check-By: sourceware.org
Received: from mail-vc0-f169.google.com (HELO mail-vc0-f169.google.com) (209.85.220.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Sep 2012 21:10:30 +0000
Received: by vcbfl13 with SMTP id fl13so7248526vcb.0        for <gdb-patches@sourceware.org>; Tue, 04 Sep 2012 14:10:30 -0700 (PDT)
Received: by 10.220.240.5 with SMTP id ky5mr7100vcb.57.1346793030076; Tue, 04 Sep 2012 14:10:30 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.58.164.66 with HTTP; Tue, 4 Sep 2012 14:10:09 -0700 (PDT)
In-Reply-To: <504661A2.9020103@oarcorp.com>
References: <50463313.9070404@oarcorp.com> <CAJaTeTozYeH=rQ8J8Wk0Xt_7ZUq+wsZ=Y0Z1y=yxxt1ts_UVvQ@mail.gmail.com> <504661A2.9020103@oarcorp.com>
From: Mike Frysinger <vapier@gentoo.org>
Date: Tue, 04 Sep 2012 21:10:00 -0000
Message-ID: <CAJaTeTpqzjdYd2W4uV-CSpz=GSSWKO_OHg-Rzmbkw0sC=GtPeA@mail.gmail.com>
Subject: Re: mips-rtems4.11 sim undefined error
To: Joel Sherrill <joel.sherrill@oarcorp.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00035.txt.bz2

On Tue, Sep 4, 2012 at 4:16 PM, Joel Sherrill wrote:
> On 09/04/2012 02:09 PM, Mike Frysinger wrote:
>> On Tue, Sep 4, 2012 at 12:57 PM, Joel Sherrill wrote:
>>>
>>> --- configure.ac    4 Jan 2012 08:28:20 -0000    1.18
>>> +++ configure.ac    4 Sep 2012 15:45:13 -0000
>>> @@ -413,7 +413,7 @@
>>>       SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
>>>       ;;
>>>     *)
>>> -    mips_extra_objs=""
>>> +    mips_extra_objs="dv-sockser.o"
>>>       ;;
>>>   esac
>>
>> considering mips_extra_objs is now the same value for all targets, i
>> would pull it out of the case statement and move it down below
>>
> How about this?
>
>
> Index: configure.ac
> ===================================================================
> RCS file: /cvs/src/src/sim/mips/configure.ac,v
> retrieving revision 1.18
> diff -u -r1.18 configure.ac
> --- configure.ac    4 Jan 2012 08:28:20 -0000    1.18
> +++ configure.ac    4 Sep 2012 20:15:37 -0000
> @@ -409,13 +409,12 @@
>    mips*tx39*)
>      hw_enabled=yes
>      hw_extra_devices="tx3904cpu tx3904irc tx3904tmr tx3904sio"
> -    mips_extra_objs="dv-sockser.o"
>
>      SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
>      ;;
>    *)
> -    mips_extra_objs=""
>      ;;
>  esac
> +mips_extra_objs="dv-sockser.o"
>  SIM_AC_OPTION_HARDWARE($hw_enabled,$hw_devices,$hw_extra_devices)
>  AC_SUBST(mips_extra_objs)

i'd move it down one line more to just above AC_SUBST :)

feel free to commit w/that minor tweak
-mike