Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Sherrill <joel.sherrill@oarcorp.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: mips-rtems4.11 sim undefined error
Date: Tue, 04 Sep 2012 20:16:00 -0000	[thread overview]
Message-ID: <504661A2.9020103@oarcorp.com> (raw)
In-Reply-To: <CAJaTeTozYeH=rQ8J8Wk0Xt_7ZUq+wsZ=Y0Z1y=yxxt1ts_UVvQ@mail.gmail.com>

On 09/04/2012 02:09 PM, Mike Frysinger wrote:
> On Tue, Sep 4, 2012 at 12:57 PM, Joel Sherrill wrote:
>> --- configure.ac    4 Jan 2012 08:28:20 -0000    1.18
>> +++ configure.ac    4 Sep 2012 15:45:13 -0000
>> @@ -413,7 +413,7 @@
>>       SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
>>       ;;
>>     *)
>> -    mips_extra_objs=""
>> +    mips_extra_objs="dv-sockser.o"
>>       ;;
>>   esac
> considering mips_extra_objs is now the same value for all targets, i
> would pull it out of the case statement and move it down below
>
How about this?

Index: configure.ac
===================================================================
RCS file: /cvs/src/src/sim/mips/configure.ac,v
retrieving revision 1.18
diff -u -r1.18 configure.ac
--- configure.ac    4 Jan 2012 08:28:20 -0000    1.18
+++ configure.ac    4 Sep 2012 20:15:37 -0000
@@ -409,13 +409,12 @@
    mips*tx39*)
      hw_enabled=yes
      hw_extra_devices="tx3904cpu tx3904irc tx3904tmr tx3904sio"
-    mips_extra_objs="dv-sockser.o"
      SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
      ;;
    *)
-    mips_extra_objs=""
      ;;
  esac
+mips_extra_objs="dv-sockser.o"
  SIM_AC_OPTION_HARDWARE($hw_enabled,$hw_devices,$hw_extra_devices)
  AC_SUBST(mips_extra_objs)

> -mike


-- 
Joel Sherrill, Ph.D.             Director of Research&   Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
     Support Available             (256) 722-9985



  reply	other threads:[~2012-09-04 20:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-04 16:58 Joel Sherrill
2012-09-04 19:09 ` Mike Frysinger
2012-09-04 20:16   ` Joel Sherrill [this message]
2012-09-04 21:10     ` Mike Frysinger
2012-09-04 21:41       ` Joel Sherrill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504661A2.9020103@oarcorp.com \
    --to=joel.sherrill@oarcorp.com \
    --cc=gdb-patches@sourceware.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox