From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-94313-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14513 invoked by alias); 4 Sep 2012 21:41:37 -0000
Received: (qmail 14447 invoked by uid 22791); 4 Sep 2012 21:41:35 -0000
X-SWARE-Spam-Status: No, hits=-2.7 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from oarmail.oarcorp.com (HELO OARmail.OARCORP.com) (67.63.146.244)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Sep 2012 21:41:22 +0000
Received: from iceland.oarcorp.com (192.168.1.171) by OARmail.OARCORP.com (192.168.2.2) with Microsoft SMTP Server (TLS) id 8.1.436.0; Tue, 4 Sep 2012 16:41:21 -0500
Message-ID: <50467581.70503@oarcorp.com>
Date: Tue, 04 Sep 2012 21:41:00 -0000
From: Joel Sherrill <joel.sherrill@oarcorp.com>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.7) Gecko/20120829 Thunderbird/10.0.7
MIME-Version: 1.0
To: Mike Frysinger <vapier@gentoo.org>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: mips-rtems4.11 sim undefined error
References: <50463313.9070404@oarcorp.com> <CAJaTeTozYeH=rQ8J8Wk0Xt_7ZUq+wsZ=Y0Z1y=yxxt1ts_UVvQ@mail.gmail.com> <504661A2.9020103@oarcorp.com> <CAJaTeTpqzjdYd2W4uV-CSpz=GSSWKO_OHg-Rzmbkw0sC=GtPeA@mail.gmail.com>
In-Reply-To: <CAJaTeTpqzjdYd2W4uV-CSpz=GSSWKO_OHg-Rzmbkw0sC=GtPeA@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-09/txt/msg00036.txt.bz2

On 09/04/2012 04:10 PM, Mike Frysinger wrote:
> On Tue, Sep 4, 2012 at 4:16 PM, Joel Sherrill wrote:
>> On 09/04/2012 02:09 PM, Mike Frysinger wrote:
>>> On Tue, Sep 4, 2012 at 12:57 PM, Joel Sherrill wrote:
>>>> --- configure.ac    4 Jan 2012 08:28:20 -0000    1.18
>>>> +++ configure.ac    4 Sep 2012 15:45:13 -0000
>>>> @@ -413,7 +413,7 @@
>>>>        SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
>>>>        ;;
>>>>      *)
>>>> -    mips_extra_objs=""
>>>> +    mips_extra_objs="dv-sockser.o"
>>>>        ;;
>>>>    esac
>>> considering mips_extra_objs is now the same value for all targets, i
>>> would pull it out of the case statement and move it down below
>>>
>> How about this?
>>
>>
>> Index: configure.ac
>> ===================================================================
>> RCS file: /cvs/src/src/sim/mips/configure.ac,v
>> retrieving revision 1.18
>> diff -u -r1.18 configure.ac
>> --- configure.ac    4 Jan 2012 08:28:20 -0000    1.18
>> +++ configure.ac    4 Sep 2012 20:15:37 -0000
>> @@ -409,13 +409,12 @@
>>     mips*tx39*)
>>       hw_enabled=yes
>>       hw_extra_devices="tx3904cpu tx3904irc tx3904tmr tx3904sio"
>> -    mips_extra_objs="dv-sockser.o"
>>
>>       SIM_SUBTARGET="$SIM_SUBTARGET -DTARGET_TX3904=1"
>>       ;;
>>     *)
>> -    mips_extra_objs=""
>>       ;;
>>   esac
>> +mips_extra_objs="dv-sockser.o"
>>   SIM_AC_OPTION_HARDWARE($hw_enabled,$hw_devices,$hw_extra_devices)
>>   AC_SUBST(mips_extra_objs)
> i'd move it down one line more to just above AC_SUBST :)
>
> feel free to commit w/that minor tweak
Committed. I hope it is is exactly the right place.

Thanks. :)
> -mike


-- 
Joel Sherrill, Ph.D.             Director of Research&   Development
joel.sherrill@OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
     Support Available             (256) 722-9985