Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] Use target_read_code in disassemble.
Date: Thu, 21 Nov 2013 02:56:00 -0000	[thread overview]
Message-ID: <CADPb22SEPJLhXTSse+GOKka2Twvkh07_RToeH5_RxL7nXv5m3A@mail.gmail.com> (raw)
In-Reply-To: <1384996594-20865-4-git-send-email-yao@codesourcery.com>

On Wed, Nov 20, 2013 at 5:16 PM, Yao Qi <yao@codesourcery.com> wrote:
> It was reviewed by Doug and nothing is changed in V3.

I think you mean unchanged.
Still ok by me. :-)

>
> gdb:
>
> 2013-11-21  Yao Qi  <yao@codesourcery.com>
>
>         * disasm.c (dis_asm_read_memory): Call target_read_code
>         instead of target_read_memory.
> ---
>  gdb/disasm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/gdb/disasm.c b/gdb/disasm.c
> index 1690395..09ae465 100644
> --- a/gdb/disasm.c
> +++ b/gdb/disasm.c
> @@ -47,7 +47,7 @@ static int
>  dis_asm_read_memory (bfd_vma memaddr, gdb_byte *myaddr, unsigned int len,
>                      struct disassemble_info *info)
>  {
> -  return target_read_memory (memaddr, myaddr, len);
> +  return target_read_code (memaddr, myaddr, len);
>  }
>
>  /* Like memory_error with slightly different parameters.  */
> --
> 1.7.7.6
>


  reply	other threads:[~2013-11-21  1:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21  1:34 [PATCH 0/3 V3] Cache code access for disassemble Yao Qi
2013-11-21  1:18 ` [PATCH 3/3] Use target_read_code in disassemble Yao Qi
2013-11-21  2:56   ` Doug Evans [this message]
2013-11-21  1:18 ` [PATCH 1/3] Renaming in target-dcache.c Yao Qi
2013-11-21  1:47   ` Doug Evans
2013-11-21  3:05     ` Yao Qi
2013-11-21  1:18 ` [PATCH 2/3] set/show code-cache Yao Qi
2013-11-21  3:33   ` Yao Qi
2013-11-21  5:06     ` Eli Zaretskii
2013-11-21 12:21     ` Pedro Alves
2013-11-21 14:03       ` Yao Qi
2013-11-21 16:13         ` Eli Zaretskii
2013-11-22  1:51           ` Yao Qi
2013-11-21 20:50       ` Doug Evans
2013-11-21 19:38     ` Tom Tromey
2013-11-21 21:06       ` Doug Evans
2013-11-21 21:17         ` Tom Tromey
2013-11-22  0:38           ` Doug Evans
2013-11-22  2:19           ` Yao Qi
2013-11-22  7:43             ` Eli Zaretskii
2013-11-24  9:02 ` [PATCH 0/3 V3] Cache code access for disassemble Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADPb22SEPJLhXTSse+GOKka2Twvkh07_RToeH5_RxL7nXv5m3A@mail.gmail.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox