Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <yao@codesourcery.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Doug Evans <dje@google.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/3] set/show code-cache
Date: Fri, 22 Nov 2013 02:19:00 -0000	[thread overview]
Message-ID: <528EB834.1080205@codesourcery.com> (raw)
In-Reply-To: <87k3g1foiq.fsf@fleche.redhat.com>

On 11/22/2013 05:11 AM, Tom Tromey wrote:
> I generally try not to require people to fix existing problems.
> My view is that patch submitters aren't responsible for the context; and
> that if it matters that much to me, I can fix it myself.  (On occasion I
> may ask nicely though...)
> 

I'd like to fix existing problems related to my submissions.  Patch
below updates "ON" and "OFF" in doc in lower case.

> But, I think it's ok to require that new bad cases not go in, as a
> general rule.

Agreed.

-- 
Yao (齐尧)

gdb/doc:

2013-11-22  Yao Qi  <yao@codesourcery.com>

	* gdb.texinfo (Caching Target Data): Replace "ON" with "on".
	(Maintenance Commands): Replace "ON" and "OFF" with "on" and
	"off" respectively.
---
 gdb/doc/gdb.texinfo |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 3371835..0359570 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -10861,8 +10861,8 @@ Show the current state of the obsolete remotecache flag.
 @kindex set stack-cache
 @item set stack-cache on
 @itemx set stack-cache off
-Enable or disable caching of stack accesses.  When @code{ON}, use
-caching.  By default, this option is @code{ON}.
+Enable or disable caching of stack accesses.  When @code{on}, use
+caching.  By default, this option is @code{on}.
 
 @kindex show stack-cache
 @item show stack-cache
@@ -37545,7 +37545,7 @@ compiled with the @samp{-pg} compiler option.
 @item maint set show-debug-regs
 @itemx maint show show-debug-regs
 Control whether to show variables that mirror the hardware debug
-registers.  Use @code{ON} to enable, @code{OFF} to disable.  If
+registers.  Use @code{on} to enable, @code{off} to disable.  If
 enabled, the debug registers values are shown when @value{GDBN} inserts or
 removes a hardware breakpoint or watchpoint, and when the inferior
 triggers a hardware-assisted breakpoint or watchpoint.
-- 
1.7.7.6


  parent reply	other threads:[~2013-11-22  1:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21  1:34 [PATCH 0/3 V3] Cache code access for disassemble Yao Qi
2013-11-21  1:18 ` [PATCH 3/3] Use target_read_code in disassemble Yao Qi
2013-11-21  2:56   ` Doug Evans
2013-11-21  1:18 ` [PATCH 1/3] Renaming in target-dcache.c Yao Qi
2013-11-21  1:47   ` Doug Evans
2013-11-21  3:05     ` Yao Qi
2013-11-21  1:18 ` [PATCH 2/3] set/show code-cache Yao Qi
2013-11-21  3:33   ` Yao Qi
2013-11-21  5:06     ` Eli Zaretskii
2013-11-21 12:21     ` Pedro Alves
2013-11-21 14:03       ` Yao Qi
2013-11-21 16:13         ` Eli Zaretskii
2013-11-22  1:51           ` Yao Qi
2013-11-21 20:50       ` Doug Evans
2013-11-21 19:38     ` Tom Tromey
2013-11-21 21:06       ` Doug Evans
2013-11-21 21:17         ` Tom Tromey
2013-11-22  0:38           ` Doug Evans
2013-11-22  2:19           ` Yao Qi [this message]
2013-11-22  7:43             ` Eli Zaretskii
2013-11-24  9:02 ` [PATCH 0/3 V3] Cache code access for disassemble Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528EB834.1080205@codesourcery.com \
    --to=yao@codesourcery.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox