From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Yao Qi <yao@codesourcery.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/3] set/show code-cache
Date: Thu, 21 Nov 2013 21:17:00 -0000 [thread overview]
Message-ID: <87k3g1foiq.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CADPb22QeSOxno1LNhJat=AMwA5Lp-3DvsPkpFtSAMD-W9pbymA@mail.gmail.com> (Doug Evans's message of "Thu, 21 Nov 2013 12:49:50 -0800")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
Tom> It seems unusual to have "ON" in upper case.
Doug> cut-n-paste from the stack-cache case.
Doug> I forget what the rules are here.
Doug> Do we require fixing the stack-cache case first?
I don't know if we have a rule.
I generally try not to require people to fix existing problems.
My view is that patch submitters aren't responsible for the context; and
that if it matters that much to me, I can fix it myself. (On occasion I
may ask nicely though...)
But, I think it's ok to require that new bad cases not go in, as a
general rule.
Tom
next prev parent reply other threads:[~2013-11-21 21:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 1:34 [PATCH 0/3 V3] Cache code access for disassemble Yao Qi
2013-11-21 1:18 ` [PATCH 1/3] Renaming in target-dcache.c Yao Qi
2013-11-21 1:47 ` Doug Evans
2013-11-21 3:05 ` Yao Qi
2013-11-21 1:18 ` [PATCH 3/3] Use target_read_code in disassemble Yao Qi
2013-11-21 2:56 ` Doug Evans
2013-11-21 1:18 ` [PATCH 2/3] set/show code-cache Yao Qi
2013-11-21 3:33 ` Yao Qi
2013-11-21 5:06 ` Eli Zaretskii
2013-11-21 12:21 ` Pedro Alves
2013-11-21 14:03 ` Yao Qi
2013-11-21 16:13 ` Eli Zaretskii
2013-11-22 1:51 ` Yao Qi
2013-11-21 20:50 ` Doug Evans
2013-11-21 19:38 ` Tom Tromey
2013-11-21 21:06 ` Doug Evans
2013-11-21 21:17 ` Tom Tromey [this message]
2013-11-22 0:38 ` Doug Evans
2013-11-22 2:19 ` Yao Qi
2013-11-22 7:43 ` Eli Zaretskii
2013-11-24 9:02 ` [PATCH 0/3 V3] Cache code access for disassemble Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3g1foiq.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox