From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29695 invoked by alias); 21 Nov 2013 01:47:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29685 invoked by uid 89); 21 Nov 2013 01:47:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail-ve0-f180.google.com Received: from Unknown (HELO mail-ve0-f180.google.com) (209.85.128.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 21 Nov 2013 01:47:35 +0000 Received: by mail-ve0-f180.google.com with SMTP id jz11so4275648veb.25 for ; Wed, 20 Nov 2013 17:47:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=H+8Q/E9e43P7n71DjO3fDmuGex23/bPU/Hoc2KC99Sw=; b=aJ6WEmbo5rXg0LqA+TZe7zbSslMJDJ0XqG68Y9/NbDPAJYM8TEg2Xx0MpwWysist5p 3oqlvxq/ceLhJD4+tsnMlzftkeS5IJ7B6LkquegeXRYRFdGCPiWPs0PETpIfpV6FpG3L 17xNxiD3f0H/r/9Pkf0kwNw/Y4dckLDIIG9wu9IIlETS5yfNdCoVtpm32aJaEa6QHYRY CEgCXLze94sTBBWdnOsBf286kIMUFmjs7RjgcTJjULzg073PoJEuHmy2ZjqdLXCvmPx9 Z5BuySPhrGJ7HEElc3ECZl3E1NkYr7bVS668hTgvOTpOroOV+43hqhwksjg44e5Q51h8 a+3A== X-Gm-Message-State: ALoCoQnsxyNp4+Et/f4BPIWZJhWlSWxEutHRRF31zC5t3ENE3c3f+6suHL4q3FyzCNRNJJCxWmxS4cltQppFn1s6PmkZcl8e8u+Z6M17Fghligtcmg2asK5YmWiHxv3ulnn/pPsAhufzHs66drPh5RtrOfLeFhzt8m7IweC1TKzqQDyvr65ojAhwzgI72/RHqwmi9Xn6SLNYe425SZN1+tZZj+MNNd6oGw== MIME-Version: 1.0 X-Received: by 10.58.46.171 with SMTP id w11mr3262655vem.5.1384998447275; Wed, 20 Nov 2013 17:47:27 -0800 (PST) Received: by 10.52.163.52 with HTTP; Wed, 20 Nov 2013 17:47:27 -0800 (PST) In-Reply-To: <1384996594-20865-4-git-send-email-yao@codesourcery.com> References: <1384996594-20865-1-git-send-email-yao@codesourcery.com> <1384996594-20865-4-git-send-email-yao@codesourcery.com> Date: Thu, 21 Nov 2013 02:56:00 -0000 Message-ID: Subject: Re: [PATCH 3/3] Use target_read_code in disassemble. From: Doug Evans To: Yao Qi Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00618.txt.bz2 On Wed, Nov 20, 2013 at 5:16 PM, Yao Qi wrote: > It was reviewed by Doug and nothing is changed in V3. I think you mean unchanged. Still ok by me. :-) > > gdb: > > 2013-11-21 Yao Qi > > * disasm.c (dis_asm_read_memory): Call target_read_code > instead of target_read_memory. > --- > gdb/disasm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/gdb/disasm.c b/gdb/disasm.c > index 1690395..09ae465 100644 > --- a/gdb/disasm.c > +++ b/gdb/disasm.c > @@ -47,7 +47,7 @@ static int > dis_asm_read_memory (bfd_vma memaddr, gdb_byte *myaddr, unsigned int len, > struct disassemble_info *info) > { > - return target_read_memory (memaddr, myaddr, len); > + return target_read_code (memaddr, myaddr, len); > } > > /* Like memory_error with slightly different parameters. */ > -- > 1.7.7.6 >