Re: [PATCH 2/3] set/show code-cache

Doug Evans
2013-11-21T21:47:49Z

On Thu, Nov 21, 2013 at 1:11 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>
> Tom> It seems unusual to have "ON" in upper case.
>
> Doug> cut-n-paste from the stack-cache case.
>
> Doug> I forget what the rules are here.
> Doug> Do we require fixing the stack-cache case first?
>
> I don't know if we have a rule.
>
> I generally try not to require people to fix existing problems.
> My view is that patch submitters aren't responsible for the context; and
> that if it matters that much to me, I can fix it myself. (On occasion I
> may ask nicely though...)
>
> But, I think it's ok to require that new bad cases not go in, as a
> general rule.

"works for me"