Re: [PATCH 1/3 v4] Introduce common/errors.h

[Doug Evans <dje@google.com>]

On Fri, Jul 25, 2014 at 4:46 AM, Pedro Alves <palves@redhat.com> wrote:
>> Yes, eventually.  I plan to submit an initial series, in which
>> common-defs.h only includes the two config.h files, and any files
>> not including either defs.h or server.h as their first line will
>> be fixed up.  If that proves acceptable, I'll submit one or more
>> further series to move the various includes currently common to
>> defs.h and server.h into common-defs.h, and finally something to
>> switch common/target/nat files over to common-defs.h.
>
> Sounds good to me.  I've distilled this into the wiki:
>
>   https://sourceware.org/gdb/wiki/Common#Header_files_in_common_code_.28defs.h_vs_server.h.2C_etc..29
>
> Please do feel free to edit it / improve it.
>
> (obviously that can evolve if the plan is objected to and changes.)

fyi,
There is also:
https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards

which will need updating, e.g., to reference what to do for common files.