From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22473 invoked by alias); 29 Jul 2014 16:32:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22454 invoked by uid 89); 29 Jul 2014 16:32:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-vc0-f171.google.com Received: from mail-vc0-f171.google.com (HELO mail-vc0-f171.google.com) (209.85.220.171) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 29 Jul 2014 16:32:30 +0000 Received: by mail-vc0-f171.google.com with SMTP id hq11so13861993vcb.16 for ; Tue, 29 Jul 2014 09:32:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=wuwYI1jBRCGe2LIzJ5UtteZAEt4h2eYlz7G8Ns3eIkQ=; b=Z/XzUYok47nl65hWjSme+E3r1TmvPRcl6g7NpRJs4oVF9f93BcoLURbZ6iQ0YvvfYc o+4ZNtVSlrqdnu6rYFOnSNh8tInB5ovusp/LFM/TEAkQUZPEf20QR52fXOZNGtzsZK/G hnEmWhT4Pxy8bzTdvJPDHCqOVXB/g6EjWd2rvUJxOuVoOTaG0Q+RJKAYmLia6a2Lpp5N Xd8Uvu5+fOR0E0BAnfAT2BSH/3GUslU/P4C8uxQKVzS7srv1g8eVDzUQ4xlISt4CWD8i P/eFKvu4oniCnMbwWsxAh75+Ekxk4MVgERbOU3iUpvdaXsBC3nBEKjapGxakpHf+bgf6 p4Tw== X-Gm-Message-State: ALoCoQkZPBgtqoUg8vvAS82J0qHBnvJJ/jfcrPDuNh3/jGdo2HgaqLNBdTN0DyszSN/m3KM0b924 MIME-Version: 1.0 X-Received: by 10.220.192.129 with SMTP id dq1mr2979326vcb.57.1406651548485; Tue, 29 Jul 2014 09:32:28 -0700 (PDT) Received: by 10.52.28.233 with HTTP; Tue, 29 Jul 2014 09:32:28 -0700 (PDT) In-Reply-To: <53D2438C.8040009@redhat.com> References: <1406206287-6817-1-git-send-email-gbenson@redhat.com> <1406206287-6817-2-git-send-email-gbenson@redhat.com> <53D1053E.6030902@redhat.com> <21457.18385.59886.323894@ruffy.mtv.corp.google.com> <20140725083642.GA4812@blade.nx> <53D22F22.4030101@redhat.com> <20140725111653.GA6301@blade.nx> <53D2438C.8040009@redhat.com> Date: Tue, 29 Jul 2014 16:44:00 -0000 Message-ID: Subject: Re: [PATCH 1/3 v4] Introduce common/errors.h From: Doug Evans To: Pedro Alves Cc: Gary Benson , gdb-patches , Tom Tromey Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-07/txt/msg00761.txt.bz2 On Fri, Jul 25, 2014 at 4:46 AM, Pedro Alves wrote: >> Yes, eventually. I plan to submit an initial series, in which >> common-defs.h only includes the two config.h files, and any files >> not including either defs.h or server.h as their first line will >> be fixed up. If that proves acceptable, I'll submit one or more >> further series to move the various includes currently common to >> defs.h and server.h into common-defs.h, and finally something to >> switch common/target/nat files over to common-defs.h. > > Sounds good to me. I've distilled this into the wiki: > > https://sourceware.org/gdb/wiki/Common#Header_files_in_common_code_.28defs.h_vs_server.h.2C_etc..29 > > Please do feel free to edit it / improve it. > > (obviously that can evolve if the plan is objected to and changes.) fyi, There is also: https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards which will need updating, e.g., to reference what to do for common files.