Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: gdb-patches@sourceware.org
Cc: Doug Evans <dje@google.com>, Pedro Alves <palves@redhat.com>,
	       Tom Tromey <tromey@redhat.com>
Subject: [PATCH 3/3 v4] Make gdbserver CORE_ADDR unsigned
Date: Thu, 24 Jul 2014 13:08:00 -0000	[thread overview]
Message-ID: <1406206287-6817-4-git-send-email-gbenson@redhat.com> (raw)
In-Reply-To: <1406206287-6817-1-git-send-email-gbenson@redhat.com>

gdbserver defines CORE_ADDR to be signed.  This seems erroneous to
me; and furthermore likely to cause problems in common/, as it is
different from gdb's definition.

gdb/gdbserver/
2014-07-24  Tom Tromey  <tromey@redhat.com>
	    Gary Benson  <gbenson@redhat.com>

	* server.h (CORE_ADDR): Now unsigned.
---
 gdb/gdbserver/ChangeLog |    5 +++++
 gdb/gdbserver/server.h  |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/gdb/gdbserver/server.h b/gdb/gdbserver/server.h
index 6eb1a16..2d55513 100644
--- a/gdb/gdbserver/server.h
+++ b/gdb/gdbserver/server.h
@@ -87,7 +87,7 @@ typedef unsigned char gdb_byte;
 
 /* FIXME: This should probably be autoconf'd for.  It's an integer type at
    least the size of a (void *).  */
-typedef long long CORE_ADDR;
+typedef unsigned long long CORE_ADDR;
 
 typedef long long LONGEST;
 typedef unsigned long long ULONGEST;
-- 
1.7.1


  parent reply	other threads:[~2014-07-24 12:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24 12:51 [PATCH 0/3 v4] Common code cleanups (part 1) Gary Benson
2014-07-24 12:51 ` [PATCH 1/3 v4] Introduce common/errors.h Gary Benson
2014-07-24 13:24   ` Pedro Alves
2014-07-24 18:03     ` Doug Evans
2014-07-25  8:51       ` Gary Benson
2014-07-25 10:32         ` Pedro Alves
2014-07-25 11:38           ` Gary Benson
2014-07-25 12:13             ` Pedro Alves
2014-07-25 13:34               ` Gary Benson
2014-07-29 16:44               ` Doug Evans
2014-07-29 17:45                 ` Pedro Alves
2014-07-30  9:43                   ` Gary Benson
2014-07-25 10:19       ` Pedro Alves
2014-07-24 17:52   ` Doug Evans
2014-07-24 22:39     ` Doug Evans
2014-07-25  9:34     ` Gary Benson
2014-07-28 20:16       ` Doug Evans
2014-07-24 12:51 ` [PATCH 2/3 v4] Remove some GDBSERVER checks from linux-ptrace Gary Benson
2014-07-24 13:25   ` Pedro Alves
2014-07-24 14:09     ` Tom Tromey
2014-07-24 14:17       ` Pedro Alves
2014-07-24 14:13     ` [PATCH 2/3 v5] " Gary Benson
2014-07-24 14:25       ` Pedro Alves
2014-07-24 15:05         ` Gary Benson
2014-07-24 13:08 ` Gary Benson [this message]
2014-07-24 13:36   ` [PATCH 3/3 v4] Make gdbserver CORE_ADDR unsigned Pedro Alves
2014-07-24 14:07     ` Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1406206287-6817-4-git-send-email-gbenson@redhat.com \
    --to=gbenson@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox