From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Gary Benson <gbenson@redhat.com>,
gdb-patches@sourceware.org, Doug Evans <dje@google.com>
Subject: Re: [PATCH 2/3 v4] Remove some GDBSERVER checks from linux-ptrace
Date: Thu, 24 Jul 2014 14:09:00 -0000 [thread overview]
Message-ID: <87oaweonp4.fsf@fleche.redhat.com> (raw)
In-Reply-To: <53D108F0.9060100@redhat.com> (Pedro Alves's message of "Thu, 24 Jul 2014 14:24:00 +0100")
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>> + current_ptrace_options |= PTRACE_O_TRACECLONE |
>> + (additional_flags & ~(PTRACE_O_TRACESYSGOOD
>> + | PTRACE_O_TRACEVFORKDONE));
Pedro> This isn't right. That enables e.g., PTRACE_O_TRACEEXIT, for example,
Pedro> and possibly invalid flags even.
I don't see how that can happen. I think the "&" prevents it.
Pedro> Please reverse that and spell out the flags we want here
Pedro> explicitly, like:
Pedro> current_ptrace_options |= PTRACE_O_TRACECLONE;
Pedro> current_ptrace_options |= (additional_flags & (PTRACE_O_TRACEFORK
Pedro> | PTRACE_O_TRACEVFORK
Pedro> | PTRACE_O_TRACEEXEC));
Though FWIW this does seem clearer.
Tom
next prev parent reply other threads:[~2014-07-24 14:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 12:51 [PATCH 0/3 v4] Common code cleanups (part 1) Gary Benson
2014-07-24 12:51 ` [PATCH 1/3 v4] Introduce common/errors.h Gary Benson
2014-07-24 13:24 ` Pedro Alves
2014-07-24 18:03 ` Doug Evans
2014-07-25 8:51 ` Gary Benson
2014-07-25 10:32 ` Pedro Alves
2014-07-25 11:38 ` Gary Benson
2014-07-25 12:13 ` Pedro Alves
2014-07-25 13:34 ` Gary Benson
2014-07-29 16:44 ` Doug Evans
2014-07-29 17:45 ` Pedro Alves
2014-07-30 9:43 ` Gary Benson
2014-07-25 10:19 ` Pedro Alves
2014-07-24 17:52 ` Doug Evans
2014-07-24 22:39 ` Doug Evans
2014-07-25 9:34 ` Gary Benson
2014-07-28 20:16 ` Doug Evans
2014-07-24 12:51 ` [PATCH 2/3 v4] Remove some GDBSERVER checks from linux-ptrace Gary Benson
2014-07-24 13:25 ` Pedro Alves
2014-07-24 14:09 ` Tom Tromey [this message]
2014-07-24 14:17 ` Pedro Alves
2014-07-24 14:13 ` [PATCH 2/3 v5] " Gary Benson
2014-07-24 14:25 ` Pedro Alves
2014-07-24 15:05 ` Gary Benson
2014-07-24 13:08 ` [PATCH 3/3 v4] Make gdbserver CORE_ADDR unsigned Gary Benson
2014-07-24 13:36 ` Pedro Alves
2014-07-24 14:07 ` Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaweonp4.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox