Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Gary Benson <gbenson@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Doug Evans <dje@google.com>,
	gdb-patches@sourceware.org,        Tom Tromey <tromey@redhat.com>
Subject: Re: [PATCH 1/3 v4] Introduce common/errors.h
Date: Fri, 25 Jul 2014 11:38:00 -0000	[thread overview]
Message-ID: <20140725111653.GA6301@blade.nx> (raw)
In-Reply-To: <53D22F22.4030101@redhat.com>

Pedro Alves wrote:
> On 07/25/2014 09:36 AM, Gary Benson wrote:
> > I'm working on this now.  My plan is to have gdb/common/common-defs.h
> > (which includes config.h and the correct gnulib config.h) and have
> > defs.h and server.h include common-defs.h as the first line.  By the
> > end of that series most every file will include defs.h or server.h
> > and no file will include config.h.
> 
> I think you meant, that files in gdb will include defs.h, files in
> gdbserver will include server.h, and files in the shared directories
> will include common-defs.h as the first line.

Yes, eventually.  I plan to submit an initial series, in which
common-defs.h only includes the two config.h files, and any files
not including either defs.h or server.h as their first line will
be fixed up.  If that proves acceptable, I'll submit one or more
further series to move the various includes currently common to
defs.h and server.h into common-defs.h, and finally something to
switch common/target/nat files over to common-defs.h.  That last
bit may need to end up mixed in with parts of the common-cleanups
series.

Cheers,
Gary

-- 
http://gbenson.net/


  reply	other threads:[~2014-07-25 11:16 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24 12:51 [PATCH 0/3 v4] Common code cleanups (part 1) Gary Benson
2014-07-24 12:51 ` [PATCH 2/3 v4] Remove some GDBSERVER checks from linux-ptrace Gary Benson
2014-07-24 13:25   ` Pedro Alves
2014-07-24 14:09     ` Tom Tromey
2014-07-24 14:17       ` Pedro Alves
2014-07-24 14:13     ` [PATCH 2/3 v5] " Gary Benson
2014-07-24 14:25       ` Pedro Alves
2014-07-24 15:05         ` Gary Benson
2014-07-24 12:51 ` [PATCH 1/3 v4] Introduce common/errors.h Gary Benson
2014-07-24 13:24   ` Pedro Alves
2014-07-24 18:03     ` Doug Evans
2014-07-25  8:51       ` Gary Benson
2014-07-25 10:32         ` Pedro Alves
2014-07-25 11:38           ` Gary Benson [this message]
2014-07-25 12:13             ` Pedro Alves
2014-07-25 13:34               ` Gary Benson
2014-07-29 16:44               ` Doug Evans
2014-07-29 17:45                 ` Pedro Alves
2014-07-30  9:43                   ` Gary Benson
2014-07-25 10:19       ` Pedro Alves
2014-07-24 17:52   ` Doug Evans
2014-07-24 22:39     ` Doug Evans
2014-07-25  9:34     ` Gary Benson
2014-07-28 20:16       ` Doug Evans
2014-07-24 13:08 ` [PATCH 3/3 v4] Make gdbserver CORE_ADDR unsigned Gary Benson
2014-07-24 13:36   ` Pedro Alves
2014-07-24 14:07     ` Gary Benson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140725111653.GA6301@blade.nx \
    --to=gbenson@redhat.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox