From: Doug Evans <dje@google.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFC 2/3] Perf test framework
Date: Sun, 22 Sep 2013 23:14:00 -0000 [thread overview]
Message-ID: <CADPb22R8sPU9fBMYHt03GKuvwMcwNP=NQy=FwX8XuKXWeQLeZQ@mail.gmail.com> (raw)
In-Reply-To: <523E5BB8.1080406@codesourcery.com>
On Sat, Sep 21, 2013 at 7:53 PM, Yao Qi <yao@codesourcery.com> wrote:
> On 09/21/2013 12:51 AM, Doug Evans wrote:
>>>
>>> I was wondering that we can support json format, so I create class
>>> >PerfTestConfig and perftest.ini is used to determine which format to
>>> >be used. I agree that we can remove PerfTestConfig since we
>>> >only support only one format (plain text) nowadays.
>>
>> Hi. I wasn't suggesting removing support for more reporting formats.
>> We'll be adding our own.:-)
>>
>> I'm just wondering, if all that pertest.ini will contain is the report
>> format, do we need it?
>
>
> perftest.ini only contains report format so far, but the perf test framework
> needs more and more customizations, so perftest.ini will contain more
> stuffs.
>
>
>> Or, can we specify the format (and whatever else is desired/needed)
>> via some other means?
>
>
> by env var? I thought of this, but this doesn't scale to me, if we have
> more to set.
No, I wasn't suggesting using env vars ... :-)
[Yikes!]
I was thinking of just python.
>> How will the user specify the desired report format?
>>
>
> in testsuite/perftest.ini
> [Reporter]
> type = TextReporter
>
> In short, we don't have anything to customize in perf test, so I am OK to
> remove PerfTestConfig. Once we want to do customization, I still prefer to
> do it through config file, like perftest.ini.
I'm all for incremental complication.
next prev parent reply other threads:[~2013-09-22 23:14 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 13:01 [RFC] GDB performance testing infrastructure Yao Qi
2013-08-21 20:39 ` Tom Tromey
2013-08-27 6:21 ` Yao Qi
2013-08-27 13:49 ` Agovic, Sanimir
2013-08-28 3:04 ` Yao Qi
2013-09-19 0:36 ` Doug Evans
2013-08-28 4:17 ` [RFC 0/3] GDB Performance testing Yao Qi
2013-08-28 4:17 ` [RFC 1/3] New make target 'check-perf' and new dir gdb.perf Yao Qi
2013-08-28 9:40 ` Agovic, Sanimir
2013-09-19 17:47 ` Doug Evans
2013-09-20 19:00 ` Tom Tromey
2013-09-20 18:59 ` Tom Tromey
2013-08-28 4:17 ` [RFC 2/3] Perf test framework Yao Qi
2013-08-28 9:57 ` Agovic, Sanimir
2013-09-03 1:45 ` Yao Qi
2013-09-03 6:38 ` Agovic, Sanimir
2013-09-19 19:09 ` Doug Evans
2013-09-20 8:04 ` Yao Qi
2013-09-20 16:51 ` Doug Evans
2013-09-22 2:54 ` Yao Qi
2013-09-22 23:14 ` Doug Evans [this message]
2013-09-20 17:12 ` Doug Evans
2013-08-28 4:17 ` [RFC 3/3] Test on solib load and unload Yao Qi
2013-08-28 4:27 ` Yao Qi
2013-08-28 11:31 ` Agovic, Sanimir
2013-09-03 1:59 ` Yao Qi
2013-09-03 6:33 ` Agovic, Sanimir
2013-09-02 15:24 ` Blanc, Nicolas
2013-09-03 2:04 ` Yao Qi
2013-09-03 7:50 ` Blanc, Nicolas
2013-09-19 22:45 ` Doug Evans
2013-09-20 19:19 ` Tom Tromey
2013-10-05 0:34 ` Doug Evans
2013-10-07 16:31 ` Tom Tromey
2013-09-22 6:25 ` Yao Qi
2013-09-23 0:14 ` Doug Evans
2013-09-24 2:31 ` Yao Qi
2013-10-05 0:37 ` Doug Evans
2013-09-20 19:14 ` Tom Tromey
2013-09-19 17:25 ` [RFC 0/3] GDB Performance testing Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22R8sPU9fBMYHt03GKuvwMcwNP=NQy=FwX8XuKXWeQLeZQ@mail.gmail.com' \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox