From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2576 invoked by alias); 22 Sep 2013 23:14:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2564 invoked by uid 89); 22 Sep 2013 23:14:13 -0000 Received: from mail-ie0-f172.google.com (HELO mail-ie0-f172.google.com) (209.85.223.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sun, 22 Sep 2013 23:14:13 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: mail-ie0-f172.google.com Received: by mail-ie0-f172.google.com with SMTP id x13so5317122ief.3 for ; Sun, 22 Sep 2013 16:14:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=FB3PmADyWwu8nvMR1whGuj2ifTPE+b4vyjJ3n/ML7Ck=; b=YmLVAguVCNFp+G/vI6ucEd2uZGV09rmJsQahE0VA3XyZ2GPlE0CQOhK3jYZU7vwFrO 3obk8h1I4PBLEdwwayOlDZHSC/PPsgZYxG8PfCYrDUx51EdYL1R/W5W69NEFBps6zmzR rjHbkJ92/OD3J9AqC98KzSCxSd3lHUl3347k3+qyqAwnctannDfip3cfXSQG/pEthL2E am+dMNF9L5GCyRBwtDQDzmhkja/ZJ0oVhDdYaelxOx5kR5DjzPYPfIhdlo669ElzCLDD O4OppRCsmsnFSwHKwX+SvjPhej3rZwvAag1ccVijuG9qJVBGaAdM60x/7CJ6QNkyKsqw RlaQ== X-Gm-Message-State: ALoCoQmXLZC+qGvM/6pd+C+JUsykz1DKvyy2WwyuZWsqA/s1gVJX4rrutyVgYfb2lvBo0tEHHKjOCJFkQg1o0pN3Bhm4j/XtJBCmTUMQMe+iy9JGVOnX9Fv9IYmzrzPxCJi9OnaRZ2KAY0C9Y2UCRVNaVq/xRFJT2zN61600VwvcEgLf2fnG6MKWYsI/SkDAN6Hc6dpk9fVO4u1JZFNgiPEo59PNogk0tQ== MIME-Version: 1.0 X-Received: by 10.50.7.101 with SMTP id i5mr10335209iga.48.1379891651145; Sun, 22 Sep 2013 16:14:11 -0700 (PDT) Received: by 10.64.31.100 with HTTP; Sun, 22 Sep 2013 16:14:10 -0700 (PDT) In-Reply-To: <523E5BB8.1080406@codesourcery.com> References: <520B7F70.6070207@codesourcery.com> <1377663394-4975-1-git-send-email-yao@codesourcery.com> <1377663394-4975-3-git-send-email-yao@codesourcery.com> <21051.19430.251374.942418@ruffy.mtv.corp.google.com> <523C015E.30902@codesourcery.com> <523E5BB8.1080406@codesourcery.com> Date: Sun, 22 Sep 2013 23:14:00 -0000 Message-ID: Subject: Re: [RFC 2/3] Perf test framework From: Doug Evans To: Yao Qi Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00803.txt.bz2 On Sat, Sep 21, 2013 at 7:53 PM, Yao Qi wrote: > On 09/21/2013 12:51 AM, Doug Evans wrote: >>> >>> I was wondering that we can support json format, so I create class >>> >PerfTestConfig and perftest.ini is used to determine which format to >>> >be used. I agree that we can remove PerfTestConfig since we >>> >only support only one format (plain text) nowadays. >> >> Hi. I wasn't suggesting removing support for more reporting formats. >> We'll be adding our own.:-) >> >> I'm just wondering, if all that pertest.ini will contain is the report >> format, do we need it? > > > perftest.ini only contains report format so far, but the perf test framework > needs more and more customizations, so perftest.ini will contain more > stuffs. > > >> Or, can we specify the format (and whatever else is desired/needed) >> via some other means? > > > by env var? I thought of this, but this doesn't scale to me, if we have > more to set. No, I wasn't suggesting using env vars ... :-) [Yikes!] I was thinking of just python. >> How will the user specify the desired report format? >> > > in testsuite/perftest.ini > [Reporter] > type = TextReporter > > In short, we don't have anything to customize in perf test, so I am OK to > remove PerfTestConfig. Once we want to do customization, I still prefer to > do it through config file, like perftest.ini. I'm all for incremental complication.