From: Doug Evans <dje@google.com>
To: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] remove duplicates in search_symbols
Date: Fri, 19 Jul 2013 21:51:00 -0000 [thread overview]
Message-ID: <CADPb22Q9PdFgG7M0zrge3cNyjiafTWaAECN99MOQDxqPB_2yOQ@mail.gmail.com> (raw)
In-Reply-To: <yjt2ppvmu3ae.fsf@ruffy.mtv.corp.google.com>
On Sat, Jun 15, 2013 at 8:45 PM, Doug Evans <dje@google.com> wrote:
> Hi.
> Depending on the app a large number of duplicates can be found
> by search_symbols. This patch removes the dups.
>
> It also will change the output of "info fun|var|types" to be sorted
> by file name.
>
> Regression tested on amd64-linux, with/without fission.
>
> Ok to check in?
>
> 2013-06-15 Doug Evans <dje@google.com>
>
> * symtab.c (do_free_search_symbols_cleanup): Change arg to,
> effectively, struct symbol_search **.
> (make_cleanup_free_search_symbols): Change arg to struct symbol_search **.
> All callers updated.
> (compare_search_syms): Compare symtab file name and block as well.
> (search_symbols_equal): New function.
> (sort_search_symbols_remove_dups): Renamed from sort_search_symbols.
> New args new_head, new_tail. Result is now void. Remove dups after
> sorting the symbols.
> (search_symbols): Sort all found symbols once, after all have been found,
> and remove duplicates. Simplify cleanup tracking of result.
> * symtab.h (make_cleanup_free_search_symbols): Update prototype.
Ping.
next prev parent reply other threads:[~2013-07-19 21:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 4:04 Doug Evans
2013-07-19 21:51 ` Doug Evans [this message]
2013-07-22 15:39 ` Tom Tromey
2013-08-01 23:50 ` Doug Evans
2013-08-02 3:39 ` Keith Seitz
2013-08-02 13:46 ` Tom Tromey
2013-08-02 16:53 ` Doug Evans
2013-08-02 17:00 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22Q9PdFgG7M0zrge3cNyjiafTWaAECN99MOQDxqPB_2yOQ@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox