From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-103530-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 4598 invoked by alias); 19 Jul 2013 21:51:58 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 4589 invoked by uid 89); 19 Jul 2013 21:51:58 -0000
X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1
Received: from Unknown (HELO mail-ie0-f182.google.com) (209.85.223.182)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 19 Jul 2013 21:51:57 +0000
Received: by mail-ie0-f182.google.com with SMTP id s9so10673080iec.13        for <gdb-patches@sourceware.org>; Fri, 19 Jul 2013 14:51:50 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=google.com; s=20120113;        h=mime-version:in-reply-to:references:date:message-id:subject:from:to         :content-type:x-gm-message-state;        bh=p/b4HKB6pkPbRApqwkmcZxCIEJYpvIQxdaZ6D3a149Q=;        b=Bqgr9oi2syrd52RwOcelLB0bSVj30cKlsJ9bTHn+0Mv3oY9qjCEwB++30Iyz4wD8tt         gRsmRBM3PVBt3Hf6jSHDMNG1GNxNnsXfP/Ir2Y1+lK2B78ALi29Ez11PH8xJznNs2TdB         Kq2/IMUnWH9qhm1j4ATgqw2pkhecve3P1ne2nOa3x+t40NxMYfqAAjhadB7rSxWzxypp         aC+OiNgUyQ+uiBfZvH2Vr3elJPzhDrd79tFAS9a/wP6Hj5ofUSsB3PYW1C67iV2uZjDg         jwli/6EO25uh6l0Jy3+J/CG/HY5iwbsVW6CJKoO9UXkc1ouqMRognHCYDHAA6OsKakHx         8RHw==
MIME-Version: 1.0
X-Received: by 10.50.136.230 with SMTP id qd6mr4222537igb.4.1374270710010; Fri, 19 Jul 2013 14:51:50 -0700 (PDT)
Received: by 10.64.62.67 with HTTP; Fri, 19 Jul 2013 14:51:49 -0700 (PDT)
In-Reply-To: <yjt2ppvmu3ae.fsf@ruffy.mtv.corp.google.com>
References: <yjt2ppvmu3ae.fsf@ruffy.mtv.corp.google.com>
Date: Fri, 19 Jul 2013 21:51:00 -0000
Message-ID: <CADPb22Q9PdFgG7M0zrge3cNyjiafTWaAECN99MOQDxqPB_2yOQ@mail.gmail.com>
Subject: Re: [RFA] remove duplicates in search_symbols
From: Doug Evans <dje@google.com>
To: gdb-patches <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Gm-Message-State: ALoCoQn2UOs5vBQk7M/86rJByHo6DCSekb8V/VcqcXqiLhAonREZSOm1bf9KgBm5NcVixzrZtYFwCvsTKDApDFWZuTGZ93JMgGOYWxYRLK2QXqnNSzCIRglnjT1J0/YEE1mi+u3hQCmU6Xs9wyu/Hy7NbxGWD6r4jyqxnNSg5TX8G/aUcDkyXt6XY9oijHcSEiBw1LZYI+9S7huxMUXbd1yvjCrX2DAdIQ==
X-SW-Source: 2013-07/txt/msg00470.txt.bz2

On Sat, Jun 15, 2013 at 8:45 PM, Doug Evans <dje@google.com> wrote:
> Hi.
> Depending on the app a large number of duplicates can be found
> by search_symbols.  This patch removes the dups.
>
> It also will change the output of "info fun|var|types" to be sorted
> by file name.
>
> Regression tested on amd64-linux, with/without fission.
>
> Ok to check in?
>
> 2013-06-15  Doug Evans  <dje@google.com>
>
>         * symtab.c (do_free_search_symbols_cleanup): Change arg to,
>         effectively, struct symbol_search **.
>         (make_cleanup_free_search_symbols): Change arg to struct symbol_search **.
>         All callers updated.
>         (compare_search_syms): Compare symtab file name and block as well.
>         (search_symbols_equal): New function.
>         (sort_search_symbols_remove_dups): Renamed from sort_search_symbols.
>         New args new_head, new_tail.  Result is now void.  Remove dups after
>         sorting the symbols.
>         (search_symbols): Sort all found symbols once, after all have been found,
>         and remove duplicates.  Simplify cleanup tracking of result.
>         * symtab.h (make_cleanup_free_search_symbols): Update prototype.

Ping.