From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] remove duplicates in search_symbols
Date: Mon, 22 Jul 2013 15:39:00 -0000 [thread overview]
Message-ID: <8738r68uze.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CADPb22Q9PdFgG7M0zrge3cNyjiafTWaAECN99MOQDxqPB_2yOQ@mail.gmail.com> (Doug Evans's message of "Fri, 19 Jul 2013 14:51:49 -0700")
>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>> 2013-06-15 Doug Evans <dje@google.com>
>>
>> * symtab.c (do_free_search_symbols_cleanup): Change arg to,
>> effectively, struct symbol_search **.
>> (make_cleanup_free_search_symbols): Change arg to struct
>> symbol_search **.
>> All callers updated.
>> (compare_search_syms): Compare symtab file name and block as well.
>> (search_symbols_equal): New function.
>> (sort_search_symbols_remove_dups): Renamed from sort_search_symbols.
>> New args new_head, new_tail. Result is now void. Remove dups after
>> sorting the symbols.
>> (search_symbols): Sort all found symbols once, after all
>> have been found,
>> and remove duplicates. Simplify cleanup tracking of result.
>> * symtab.h (make_cleanup_free_search_symbols): Update prototype.
Doug> Ping.
Looks good to me.
It seems make_cleanup_free_search_symbols isn't used outside of
symtab.c.
Tom
next prev parent reply other threads:[~2013-07-22 15:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 4:04 Doug Evans
2013-07-19 21:51 ` Doug Evans
2013-07-22 15:39 ` Tom Tromey [this message]
2013-08-01 23:50 ` Doug Evans
2013-08-02 3:39 ` Keith Seitz
2013-08-02 13:46 ` Tom Tromey
2013-08-02 16:53 ` Doug Evans
2013-08-02 17:00 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738r68uze.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox