From: Keith Seitz <keiths@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] remove duplicates in search_symbols
Date: Fri, 02 Aug 2013 03:39:00 -0000 [thread overview]
Message-ID: <51FB2A02.6080703@redhat.com> (raw)
In-Reply-To: <20986.62497.975502.698564@ruffy.mtv.corp.google.com>
On 08/01/2013 04:49 PM, Doug Evans wrote:
> struct symbol_search { ... };
> extern void search_symbols (char *, enum search_domain, int, char **,
> struct symbol_search **);
> extern void free_search_symbols (struct symbol_search *);
> extern struct cleanup *make_cleanup_free_search_symbols (struct symbol_search
> **);
>
> I'm semi-ambivalent about keeping them as an exported part of the API
> so I left making them static for another pass.
FWIW, Insight uses struct symbol_search, search_symbols, and
make_cleanup_free_search_symbols. It would be nice if some sort of
public API for this was maintained.
Keith
next prev parent reply other threads:[~2013-08-02 3:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 4:04 Doug Evans
2013-07-19 21:51 ` Doug Evans
2013-07-22 15:39 ` Tom Tromey
2013-08-01 23:50 ` Doug Evans
2013-08-02 3:39 ` Keith Seitz [this message]
2013-08-02 13:46 ` Tom Tromey
2013-08-02 16:53 ` Doug Evans
2013-08-02 17:00 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51FB2A02.6080703@redhat.com \
--to=keiths@redhat.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox