From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-103964-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31532 invoked by alias); 2 Aug 2013 03:39:57 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 31505 invoked by uid 89); 2 Aug 2013 03:39:56 -0000
X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1
Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 02 Aug 2013 03:39:56 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r723dlZ5002732	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Thu, 1 Aug 2013 23:39:47 -0400
Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r723dkXt013426	(version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);	Thu, 1 Aug 2013 23:39:47 -0400
Message-ID: <51FB2A02.6080703@redhat.com>
Date: Fri, 02 Aug 2013 03:39:00 -0000
From: Keith Seitz <keiths@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Doug Evans <dje@google.com>
CC: Tom Tromey <tromey@redhat.com>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] remove duplicates in search_symbols
References: <yjt2ppvmu3ae.fsf@ruffy.mtv.corp.google.com>	<CADPb22Q9PdFgG7M0zrge3cNyjiafTWaAECN99MOQDxqPB_2yOQ@mail.gmail.com>	<8738r68uze.fsf@fleche.redhat.com> <20986.62497.975502.698564@ruffy.mtv.corp.google.com>
In-Reply-To: <20986.62497.975502.698564@ruffy.mtv.corp.google.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2013-08/txt/msg00058.txt.bz2

On 08/01/2013 04:49 PM, Doug Evans wrote:
> struct symbol_search { ... };
> extern void search_symbols (char *, enum search_domain, int, char **,
> 			    struct symbol_search **);
> extern void free_search_symbols (struct symbol_search *);
> extern struct cleanup *make_cleanup_free_search_symbols (struct symbol_search
> 							 **);
>
> I'm semi-ambivalent about keeping them as an exported part of the API
> so I left making them static for another pass.

FWIW, Insight uses struct symbol_search, search_symbols, and 
make_cleanup_free_search_symbols. It would be nice if some sort of 
public API for this was maintained.

Keith