From: Doug Evans <dje@google.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Keith Seitz <keiths@redhat.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] remove duplicates in search_symbols
Date: Fri, 02 Aug 2013 16:53:00 -0000 [thread overview]
Message-ID: <CADPb22Q0_MWssituUuwV_HqptkUQLAU06SDfMGGPqa6XFG5PrA@mail.gmail.com> (raw)
In-Reply-To: <87pptwdx41.fsf@fleche.redhat.com>
On Fri, Aug 2, 2013 at 6:46 AM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> Keith> FWIW, Insight uses struct symbol_search, search_symbols, and
> Keith> make_cleanup_free_search_symbols. It would be nice if some sort of
> Keith> public API for this was maintained.
>
> Perhaps a comment would be nice.
> I have a feeling I've gone though this more than once.
Heh. Twas my thought but I went to add such a comment and found one
already there.
/* Symbol searching */
/* Note: struct symbol_search, search_symbols, et.al. are declared
here,
instead of making them local to symtab.c, for gdbtk's sake. */
[I could make it more prevalent though. Say a comment at the
definition site of each function or some such?]
next prev parent reply other threads:[~2013-08-02 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-16 4:04 Doug Evans
2013-07-19 21:51 ` Doug Evans
2013-07-22 15:39 ` Tom Tromey
2013-08-01 23:50 ` Doug Evans
2013-08-02 3:39 ` Keith Seitz
2013-08-02 13:46 ` Tom Tromey
2013-08-02 16:53 ` Doug Evans [this message]
2013-08-02 17:00 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADPb22Q0_MWssituUuwV_HqptkUQLAU06SDfMGGPqa6XFG5PrA@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox