From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21440 invoked by alias); 2 Aug 2013 16:53:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21416 invoked by uid 89); 2 Aug 2013 16:53:37 -0000 X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RDNS_NONE,SPF_PASS autolearn=ham version=3.3.1 Received: from Unknown (HELO mail-oa0-f47.google.com) (209.85.219.47) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 02 Aug 2013 16:53:36 +0000 Received: by mail-oa0-f47.google.com with SMTP id g12so1798092oah.20 for ; Fri, 02 Aug 2013 09:53:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=FYVWl93XdVly0rioqpB1TaEcUfKxM9SwlN/8O9rUL9E=; b=jN/vTOxMrKHY9C6Lqb/n89+vXfDFLtOMg01U6pFLUl2Z1f7RZFaB1YObQGf/pB1nWM dV7/r7bom7dd+suyFIrQuMMOJEFoStsaGpUCKuP8IZ1BIV/gfy/7dB4b4YSzWpbZRcOK axiYcnlqI0KYJWKvHheH+8EodilQVYDvzmI8RziJfp7yGi6K4OT3GZp3z9eTB1DKvw56 lkFW8YE2NUMy129xhN9qzD7S3KBu90IfixurvLJuH1Z47VGybEHMJVoCRWme3NNhi7wM gdvQUu9qAAe1XefroFNGYbFvp8+XQmNgJJ8bMNRzpG+pNqe7Gh6jfLmAzUDpP1tD592M pbdQ== MIME-Version: 1.0 X-Received: by 10.50.122.65 with SMTP id lq1mr384205igb.11.1375462409112; Fri, 02 Aug 2013 09:53:29 -0700 (PDT) Received: by 10.64.239.148 with HTTP; Fri, 2 Aug 2013 09:53:29 -0700 (PDT) In-Reply-To: <87pptwdx41.fsf@fleche.redhat.com> References: <8738r68uze.fsf@fleche.redhat.com> <20986.62497.975502.698564@ruffy.mtv.corp.google.com> <51FB2A02.6080703@redhat.com> <87pptwdx41.fsf@fleche.redhat.com> Date: Fri, 02 Aug 2013 16:53:00 -0000 Message-ID: Subject: Re: [RFA] remove duplicates in search_symbols From: Doug Evans To: Tom Tromey Cc: Keith Seitz , gdb-patches Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQnM2DX5DiEQZ7jN0teHxmP13wB5Q83ACpnvPPJGTHEccrK8CPUDNm2WR6wJlSc5qWdBSvvAtoKTR4TuKhbBaG6ygo9tiUF7aVqJMNUnekb62xUK67l7KT2NOGt7YBt2R18QFA0aPM1kzhKfF3S1JoQ1NgISBu2sUpTuXhLJ8+EmAjMDHEiGPsRDBbGvp8+Nqj+34dGPlw1+4Qb/56//yVL0MXzyNw== X-SW-Source: 2013-08/txt/msg00086.txt.bz2 On Fri, Aug 2, 2013 at 6:46 AM, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> FWIW, Insight uses struct symbol_search, search_symbols, and > Keith> make_cleanup_free_search_symbols. It would be nice if some sort of > Keith> public API for this was maintained. > > Perhaps a comment would be nice. > I have a feeling I've gone though this more than once. Heh. Twas my thought but I went to add such a comment and found one already there. /* Symbol searching */ /* Note: struct symbol_search, search_symbols, et.al. are declared here, instead of making them local to symtab.c, for gdbtk's sake. */ [I could make it more prevalent though. Say a comment at the definition site of each function or some such?]