From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-103559-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5129 invoked by alias); 22 Jul 2013 15:39:47 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 5116 invoked by uid 89); 22 Jul 2013 15:39:47 -0000
X-Spam-SWARE-Status: No, score=-4.1 required=5.0 tests=AWL,BAYES_50,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1
Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 22 Jul 2013 15:39:29 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r6MFdJRN002853	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 22 Jul 2013 11:39:20 -0400
Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r6MFdIWs013603	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 22 Jul 2013 11:39:18 -0400
From: Tom Tromey <tromey@redhat.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] remove duplicates in search_symbols
References: <yjt2ppvmu3ae.fsf@ruffy.mtv.corp.google.com>	<CADPb22Q9PdFgG7M0zrge3cNyjiafTWaAECN99MOQDxqPB_2yOQ@mail.gmail.com>
Date: Mon, 22 Jul 2013 15:39:00 -0000
In-Reply-To: <CADPb22Q9PdFgG7M0zrge3cNyjiafTWaAECN99MOQDxqPB_2yOQ@mail.gmail.com>	(Doug Evans's message of "Fri, 19 Jul 2013 14:51:49 -0700")
Message-ID: <8738r68uze.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-07/txt/msg00499.txt.bz2

>>>>> "Doug" == Doug Evans <dje@google.com> writes:

>> 2013-06-15  Doug Evans  <dje@google.com>
>> 
>> * symtab.c (do_free_search_symbols_cleanup): Change arg to,
>> effectively, struct symbol_search **.
>> (make_cleanup_free_search_symbols): Change arg to struct
>> symbol_search **.
>> All callers updated.
>> (compare_search_syms): Compare symtab file name and block as well.
>> (search_symbols_equal): New function.
>> (sort_search_symbols_remove_dups): Renamed from sort_search_symbols.
>> New args new_head, new_tail.  Result is now void.  Remove dups after
>> sorting the symbols.
>> (search_symbols): Sort all found symbols once, after all
>> have been found,
>> and remove duplicates.  Simplify cleanup tracking of result.
>> * symtab.h (make_cleanup_free_search_symbols): Update prototype.

Doug> Ping.

Looks good to me.

It seems make_cleanup_free_search_symbols isn't used outside of
symtab.c.

Tom