From: Tristan Gingold <gingold@adacore.com>
To: Doug Evans <dje@google.com>
Cc: Joel Brobecker <brobecker@adacore.com>,
Tom Tromey <tromey@redhat.com>,
"gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Emit a warning for ineffective set VAR = EXP command
Date: Fri, 04 May 2012 07:59:00 -0000 [thread overview]
Message-ID: <B039E141-CC23-4819-AE89-8F14683A3F6D@adacore.com> (raw)
In-Reply-To: <CADPb22TOW-qRMEbcbNqTVwKehNwKh2e7O=yBa=U_FSodd9GT6w@mail.gmail.com>
On May 3, 2012, at 6:33 PM, Doug Evans wrote:
> On Thu, May 3, 2012 at 8:05 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>>> Ok with one more change.
>>>
>>> -gdb_test "set language ada" ".*" "set language ada"
>>> +gdb_test_no_output "set language ada"
>>
>> There is going to be some output, because this command is forcing
>> a language which does not match the frame.
>
> Ah.
Now committed.
>>> [I'm assuming the warning test has the desired affect. I don't know ada. :-)]
>>
>> Correct, it's a `='/`==' vs `:='/'=' confusion. In Ada, the comparison
>> operator is "=". The user should have used the assignment operator which
>> is ":=". The number of times I got bitten by this....
>
> It's trivial to add tests for a few more languages.
> Whether it's worth it, I don't know.
Well I don't think it is worth. Gdb testsuite is not really a pedagogic material :-)
> It may be worth it if only as an educational vehicle so people who
> don't know these other languages get exposed to them for this
> particular issue.
next prev parent reply other threads:[~2012-05-04 7:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 13:48 Tristan Gingold
2012-04-27 13:54 ` Pierre Muller
2012-04-27 16:09 ` Tom Tromey
2012-05-02 13:17 ` Tristan Gingold
2012-05-02 16:41 ` Doug Evans
2012-05-03 10:00 ` Tristan Gingold
2012-05-03 13:12 ` Doug Evans
2012-05-03 15:05 ` Joel Brobecker
2012-05-03 16:33 ` Doug Evans
2012-05-03 22:04 ` Joel Brobecker
2012-05-03 22:07 ` Doug Evans
2012-05-04 7:59 ` Tristan Gingold [this message]
2012-05-03 15:02 ` Joel Brobecker
2012-05-03 15:04 ` Tristan Gingold
2012-05-04 19:02 ` Maciej W. Rozycki
2012-05-07 10:30 ` Tristan Gingold
2012-05-07 19:36 ` Tom Tromey
2012-05-07 19:40 ` Paul_Koning
2012-05-07 20:38 ` Tom Tromey
2012-05-07 19:38 ` Joel Brobecker
2012-05-09 12:29 ` Tristan Gingold
2012-05-09 13:54 ` Paul_Koning
2012-05-09 14:10 ` Tristan Gingold
2012-05-09 14:12 ` Maciej W. Rozycki
2012-05-09 14:58 ` Paul_Koning
2012-05-09 15:38 ` Maciej W. Rozycki
2012-05-09 15:55 ` Paul_Koning
2012-05-09 14:17 ` Joel Brobecker
2012-05-10 14:11 ` Tristan Gingold
2012-05-08 6:06 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B039E141-CC23-4819-AE89-8F14683A3F6D@adacore.com \
--to=gingold@adacore.com \
--cc=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox