Re: [RFA] Emit a warning for ineffective set VAR = EXP command

[<Paul_Koning@Dell.com>]

On May 9, 2012, at 10:12 AM, Maciej W. Rozycki wrote:

> On Wed, 9 May 2012, Paul_Koning@Dell.com wrote:
> 
>>>> I think we should avoid the warning for pre/post inc/dec. This
>>>> type of expression might be a little outside the method proposed
>>>> in our documentation, but I think it's still a perfectly valid
>>>> expression that results in an assignment being performed.
>>> 
>>> I don't know who should approve this adjustment, but here is the version that deals with pre/post inc/dec.
>>> Note that it still warns for expressions such as i++ * 2.
>> 
>> If you had it walk through the elts[] list, would it then work for that case?
> 
> What do you mean by "work" here?  I think a warning for "i++ * 2" is 
> expected as that's questionable use -- the result of the multiplication is 
> discarded.  Did you mean anything else?

You're right, but it does perform an assignment (to "i") so a message saying that the statement has no effect is not accurate.  Then again, given that the statement doesn't make much sense, the fact that the message is not completely accurate isn't all that interesting -- unlike the simple "i++" it isn't a likely case in reality.

	paul