From: <Paul_Koning@Dell.com>
To: <macro@codesourcery.com>
Cc: <gingold@adacore.com>, <brobecker@adacore.com>,
<gdb-patches@sourceware.org>
Subject: Re: [RFA] Emit a warning for ineffective set VAR = EXP command
Date: Wed, 09 May 2012 15:55:00 -0000 [thread overview]
Message-ID: <9E762D6B-AB48-4D91-B33F-2C7E6078C5BE@Dell.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1205091628060.11227@tp.orcam.me.uk>
On May 9, 2012, at 11:38 AM, Maciej W. Rozycki wrote:
> On Wed, 9 May 2012, Paul_Koning@Dell.com wrote:
>
>>> What do you mean by "work" here? I think a warning for "i++ * 2" is
>>> expected as that's questionable use -- the result of the multiplication is
>>> discarded. Did you mean anything else?
>>
>> You're right, but it does perform an assignment (to "i") so a message
>> saying that the statement has no effect is not accurate. Then again,
>> given that the statement doesn't make much sense, the fact that the
>> message is not completely accurate isn't all that interesting -- unlike
>> the simple "i++" it isn't a likely case in reality.
>
> I think it's all right -- "might have no effect" is weaker than "has no
> effect" and will draw one's attention in the case of a typo or suchlike.
>
> Maciej
Good point. So I'll agree that the proposed change is fine (and no, I can't approve it either).
paul
next prev parent reply other threads:[~2012-05-09 15:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 13:48 Tristan Gingold
2012-04-27 13:54 ` Pierre Muller
2012-04-27 16:09 ` Tom Tromey
2012-05-02 13:17 ` Tristan Gingold
2012-05-02 16:41 ` Doug Evans
2012-05-03 10:00 ` Tristan Gingold
2012-05-03 13:12 ` Doug Evans
2012-05-03 15:05 ` Joel Brobecker
2012-05-03 16:33 ` Doug Evans
2012-05-03 22:04 ` Joel Brobecker
2012-05-03 22:07 ` Doug Evans
2012-05-04 7:59 ` Tristan Gingold
2012-05-03 15:02 ` Joel Brobecker
2012-05-03 15:04 ` Tristan Gingold
2012-05-04 19:02 ` Maciej W. Rozycki
2012-05-07 10:30 ` Tristan Gingold
2012-05-07 19:36 ` Tom Tromey
2012-05-07 19:40 ` Paul_Koning
2012-05-07 20:38 ` Tom Tromey
2012-05-07 19:38 ` Joel Brobecker
2012-05-09 12:29 ` Tristan Gingold
2012-05-09 13:54 ` Paul_Koning
2012-05-09 14:10 ` Tristan Gingold
2012-05-09 14:12 ` Maciej W. Rozycki
2012-05-09 14:58 ` Paul_Koning
2012-05-09 15:38 ` Maciej W. Rozycki
2012-05-09 15:55 ` Paul_Koning [this message]
2012-05-09 14:17 ` Joel Brobecker
2012-05-10 14:11 ` Tristan Gingold
2012-05-08 6:06 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9E762D6B-AB48-4D91-B33F-2C7E6078C5BE@Dell.com \
--to=paul_koning@dell.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
--cc=macro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox