Re: [RFA] Emit a warning for ineffective set VAR = EXP command

[Tristan Gingold <gingold@adacore.com>]

On May 2, 2012, at 6:40 PM, Doug Evans wrote:

> I think the convention now is to use prepare_for_testing to simplify a
> lot of the setup in the .exp file.  Grep for other uses to see how
> it's used.

Ah thanks.  I didn't start from the best .exp file.

Ok with this version ?

testsuite/
2012-05-02  Tristan Gingold  <gingold@adacore.com>

	* gdb.base/set-noassign.exp: New test.


diff --git a/gdb/testsuite/gdb.base/set-noassign.exp b/gdb/testsuite/gdb.base/set-noassign.exp
new file mode 100644
index 0000000..c9971f5
--- /dev/null
+++ b/gdb/testsuite/gdb.base/set-noassign.exp
@@ -0,0 +1,32 @@
+# Copyright 2012 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+
+if { [prepare_for_testing set-noassign.exp "set-noassign" start.c {debug nowarnings}] } {
+    return -1
+}
+
+if ![runto_main] then {
+    fail "Can't run to main"
+    return 0
+}
+
+# Verify that set command without assignment emits a warning.
+#
+gdb_test "set language ada" ".*" "set language ada"
+
+gdb_test "set x=3" \
+	"warning: Expression is not an assignment \\(and might have no effect\\)" \
+	"warning for set without assignment"