From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-90679-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25403 invoked by alias); 4 May 2012 07:59:42 -0000
Received: (qmail 25389 invoked by uid 22791); 4 May 2012 07:59:40 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0	tests=AWL,BAYES_00,KHOP_THREADED
X-Spam-Check-By: sourceware.org
Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 May 2012 07:59:27 +0000
Received: from localhost (localhost [127.0.0.1])	by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 42D69290008;	Fri,  4 May 2012 09:59:32 +0200 (CEST)
Received: from mel.act-europe.fr ([127.0.0.1])	by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024)	with ESMTP id urMG8+t4zQxm; Fri,  4 May 2012 09:59:32 +0200 (CEST)
Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67])	(using TLSv1 with cipher AES128-SHA (128/128 bits))	(No client certificate requested)	by mel.act-europe.fr (Postfix) with ESMTP id 19F1C290007;	Fri,  4 May 2012 09:59:32 +0200 (CEST)
Subject: Re: [RFA] Emit a warning for ineffective set VAR = EXP command
Mime-Version: 1.0 (Apple Message framework v1257)
Content-Type: text/plain; charset=iso-8859-1
From: Tristan Gingold <gingold@adacore.com>
In-Reply-To: <CADPb22TOW-qRMEbcbNqTVwKehNwKh2e7O=yBa=U_FSodd9GT6w@mail.gmail.com>
Date: Fri, 04 May 2012 07:59:00 -0000
Cc: Joel Brobecker <brobecker@adacore.com>, Tom Tromey <tromey@redhat.com>, "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <B039E141-CC23-4819-AE89-8F14683A3F6D@adacore.com>
References: <8781499A-A489-42D0-80B1-75136331DBDB@adacore.com> <87mx5x40uz.fsf@fleche.redhat.com> <05ADE46C-9093-4EE4-92A7-1232779DE5DC@adacore.com> <CADPb22Qaqamd1D2E-wyPEkY-3hM0w4vVu0YQQx7vVas6bsgNqw@mail.gmail.com> <98CB5870-6AB6-40FA-B3A1-9AF8269B2909@adacore.com> <CADPb22RmvAp-a-YMj0L124FY5qFq5qo2S_DCpJ6X5wP2uKC5Pg@mail.gmail.com> <20120503150512.GI15555@adacore.com> <CADPb22TOW-qRMEbcbNqTVwKehNwKh2e7O=yBa=U_FSodd9GT6w@mail.gmail.com>
To: Doug Evans <dje@google.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-05/txt/msg00121.txt.bz2


On May 3, 2012, at 6:33 PM, Doug Evans wrote:

> On Thu, May 3, 2012 at 8:05 AM, Joel Brobecker <brobecker@adacore.com> wr=
ote:
>>> Ok with one more change.
>>>=20
>>> -gdb_test "set language ada" ".*" "set language ada"
>>> +gdb_test_no_output "set language ada"
>>=20
>> There is going to be some output, because this command is forcing
>> a language which does not match the frame.
>=20
> Ah.

Now committed.

>>> [I'm assuming the warning test has the desired affect.  I don't know ad=
a. :-)]
>>=20
>> Correct, it's a `=3D'/`=3D=3D' vs `:=3D'/'=3D' confusion. In Ada, the co=
mparison
>> operator is "=3D". The user should have used the assignment operator whi=
ch
>> is ":=3D".  The number of times I got bitten by this....
>=20
> It's trivial to add tests for a few more languages.
> Whether it's worth it, I don't know.

Well I don't think it is worth.  Gdb testsuite is not really a pedagogic ma=
terial :-)

> It may be worth it if only as an educational vehicle so people who
> don't know these other languages get exposed to them for this
> particular issue.