[RFC/RFA] enable break

[RFC/RFA] enable break

[Michael Snyder]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

I happened to notice that if you say "help disable", you get a list
of sub-commands that includes "disable breakpoints", but if you say
"help enable", the list of sub-commands, does NOT include "enable
breakpoints".  It also doesn't tab-complete on "enable br<tab>".

On investigation, I discovered that the "enable breakpoints" command
is instantiated using "add_abbrev_prefix_cmd".  What the heck -- it's
not an abbreviation.  This dates back to before the current cvs repo.

Changing that call to "add_prefix_cmd" fixes the issues, and causes
no regressions when tested on amd64-linux.

OK to commit?


[-- Attachment #2: prefix.txt --]
[-- Type: text/plain, Size: 887 bytes --]

2010-06-18  Michael Snyder  <msnyder@vmware.com>

	* breakpoint.c (_initialize_breakpoint): Use add_prefix_cmd, 
	not add_abbrev_prefix_cmd, for "enable breakpoints".

Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.490
diff -u -p -r1.490 breakpoint.c
--- breakpoint.c	16 Jun 2010 18:30:30 -0000	1.490
+++ breakpoint.c	19 Jun 2010 01:03:40 -0000
@@ -11264,7 +11264,7 @@ With a subcommand you can enable tempora
 
   add_com_alias ("en", "enable", class_breakpoint, 1);
 
-  add_abbrev_prefix_cmd ("breakpoints", class_breakpoint, enable_command, _("\
+  add_prefix_cmd ("breakpoints", class_breakpoint, enable_command, _("\
 Enable some breakpoints.\n\
 Give breakpoint numbers (separated by spaces) as arguments.\n\
 This is used to cancel the effect of the \"disable\" command.\n\

Re: [RFC/RFA] enable break

[Hui Zhu]

It's test OK on i386-linux.

Thanks,
Hui

On Sat, Jun 19, 2010 at 09:12, Michael Snyder <msnyder@vmware.com> wrote:
> I happened to notice that if you say "help disable", you get a list
> of sub-commands that includes "disable breakpoints", but if you say
> "help enable", the list of sub-commands, does NOT include "enable
> breakpoints".  It also doesn't tab-complete on "enable br<tab>".
>
> On investigation, I discovered that the "enable breakpoints" command
> is instantiated using "add_abbrev_prefix_cmd".  What the heck -- it's
> not an abbreviation.  This dates back to before the current cvs repo.
>
> Changing that call to "add_prefix_cmd" fixes the issues, and causes
> no regressions when tested on amd64-linux.
>
> OK to commit?
>
>
> 2010-06-18  Michael Snyder  <msnyder@vmware.com>
>
>        * breakpoint.c (_initialize_breakpoint): Use add_prefix_cmd,
>        not add_abbrev_prefix_cmd, for "enable breakpoints".
>
> Index: breakpoint.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/breakpoint.c,v
> retrieving revision 1.490
> diff -u -p -r1.490 breakpoint.c
> --- breakpoint.c        16 Jun 2010 18:30:30 -0000      1.490
> +++ breakpoint.c        19 Jun 2010 01:03:40 -0000
> @@ -11264,7 +11264,7 @@ With a subcommand you can enable tempora
>
>   add_com_alias ("en", "enable", class_breakpoint, 1);
>
> -  add_abbrev_prefix_cmd ("breakpoints", class_breakpoint, enable_command,
> _("\
> +  add_prefix_cmd ("breakpoints", class_breakpoint, enable_command, _("\
>  Enable some breakpoints.\n\
>  Give breakpoint numbers (separated by spaces) as arguments.\n\
>  This is used to cancel the effect of the \"disable\" command.\n\
>
>

Re: [RFC/RFA] enable break

[Tom Tromey]

>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:

Michael> 2010-06-18  Michael Snyder  <msnyder@vmware.com>
Michael> 	* breakpoint.c (_initialize_breakpoint): Use add_prefix_cmd, 
Michael> 	not add_abbrev_prefix_cmd, for "enable breakpoints".

This is ok, thanks.

Tom

Re: [RFC/RFA] enable break

[Michael Snyder]

Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
> 
> Michael> 2010-06-18  Michael Snyder  <msnyder@vmware.com>
> Michael> 	* breakpoint.c (_initialize_breakpoint): Use add_prefix_cmd, 
> Michael> 	not add_abbrev_prefix_cmd, for "enable breakpoints".
> 
> This is ok, thanks.

Committed.