From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21271 invoked by alias); 19 Jun 2010 01:12:59 -0000 Received: (qmail 21263 invoked by uid 22791); 19 Jun 2010 01:12:58 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 19 Jun 2010 01:12:54 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id EDBDF57007 for ; Fri, 18 Jun 2010 18:12:51 -0700 (PDT) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost3.vmware.com (Postfix) with ESMTP id E115ECD926 for ; Fri, 18 Jun 2010 18:12:51 -0700 (PDT) Message-ID: <4C1C1993.5000908@vmware.com> Date: Sat, 19 Jun 2010 01:12:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [RFC/RFA] enable break Content-Type: multipart/mixed; boundary="------------000808080307030706040902" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-06/txt/msg00425.txt.bz2 This is a multi-part message in MIME format. --------------000808080307030706040902 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 605 I happened to notice that if you say "help disable", you get a list of sub-commands that includes "disable breakpoints", but if you say "help enable", the list of sub-commands, does NOT include "enable breakpoints". It also doesn't tab-complete on "enable br". On investigation, I discovered that the "enable breakpoints" command is instantiated using "add_abbrev_prefix_cmd". What the heck -- it's not an abbreviation. This dates back to before the current cvs repo. Changing that call to "add_prefix_cmd" fixes the issues, and causes no regressions when tested on amd64-linux. OK to commit? --------------000808080307030706040902 Content-Type: text/plain; name="prefix.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="prefix.txt" Content-length: 887 2010-06-18 Michael Snyder * breakpoint.c (_initialize_breakpoint): Use add_prefix_cmd, not add_abbrev_prefix_cmd, for "enable breakpoints". Index: breakpoint.c =================================================================== RCS file: /cvs/src/src/gdb/breakpoint.c,v retrieving revision 1.490 diff -u -p -r1.490 breakpoint.c --- breakpoint.c 16 Jun 2010 18:30:30 -0000 1.490 +++ breakpoint.c 19 Jun 2010 01:03:40 -0000 @@ -11264,7 +11264,7 @@ With a subcommand you can enable tempora add_com_alias ("en", "enable", class_breakpoint, 1); - add_abbrev_prefix_cmd ("breakpoints", class_breakpoint, enable_command, _("\ + add_prefix_cmd ("breakpoints", class_breakpoint, enable_command, _("\ Enable some breakpoints.\n\ Give breakpoint numbers (separated by spaces) as arguments.\n\ This is used to cancel the effect of the \"disable\" command.\n\ --------------000808080307030706040902--