Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFC/RFA] enable break
Date: Sat, 19 Jun 2010 01:12:00 -0000	[thread overview]
Message-ID: <4C1C1993.5000908@vmware.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

I happened to notice that if you say "help disable", you get a list
of sub-commands that includes "disable breakpoints", but if you say
"help enable", the list of sub-commands, does NOT include "enable
breakpoints".  It also doesn't tab-complete on "enable br<tab>".

On investigation, I discovered that the "enable breakpoints" command
is instantiated using "add_abbrev_prefix_cmd".  What the heck -- it's
not an abbreviation.  This dates back to before the current cvs repo.

Changing that call to "add_prefix_cmd" fixes the issues, and causes
no regressions when tested on amd64-linux.

OK to commit?


[-- Attachment #2: prefix.txt --]
[-- Type: text/plain, Size: 887 bytes --]

2010-06-18  Michael Snyder  <msnyder@vmware.com>

	* breakpoint.c (_initialize_breakpoint): Use add_prefix_cmd, 
	not add_abbrev_prefix_cmd, for "enable breakpoints".

Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.490
diff -u -p -r1.490 breakpoint.c
--- breakpoint.c	16 Jun 2010 18:30:30 -0000	1.490
+++ breakpoint.c	19 Jun 2010 01:03:40 -0000
@@ -11264,7 +11264,7 @@ With a subcommand you can enable tempora
 
   add_com_alias ("en", "enable", class_breakpoint, 1);
 
-  add_abbrev_prefix_cmd ("breakpoints", class_breakpoint, enable_command, _("\
+  add_prefix_cmd ("breakpoints", class_breakpoint, enable_command, _("\
 Enable some breakpoints.\n\
 Give breakpoint numbers (separated by spaces) as arguments.\n\
 This is used to cancel the effect of the \"disable\" command.\n\

             reply	other threads:[~2010-06-19  1:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-19  1:12 Michael Snyder [this message]
2010-06-20  6:34 ` Hui Zhu
2010-06-20 18:16 ` Tom Tromey
2010-06-21 17:39   ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1C1993.5000908@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox