From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-73841-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1634 invoked by alias); 20 Jun 2010 06:34:05 -0000
Received: (qmail 1574 invoked by uid 22791); 20 Jun 2010 06:33:49 -0000
X-SWARE-Spam-Status: No, hits= required=	tests=
Received: from mail-px0-f169.google.com (HELO mail-px0-f169.google.com) (209.85.212.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 20 Jun 2010 06:33:49 +0000
Received: by pxi14 with SMTP id 14so2757982pxi.0        for <gdb-patches@sourceware.org>; Sat, 19 Jun 2010 23:33:47 -0700 (PDT)
Received: by 10.142.1.21 with SMTP id 21mr2273270wfa.173.1277015627206; Sat, 	19 Jun 2010 23:33:47 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.143.32.8 with HTTP; Sat, 19 Jun 2010 23:33:27 -0700 (PDT)
In-Reply-To: <4C1C1993.5000908@vmware.com>
References: <4C1C1993.5000908@vmware.com>
From: Hui Zhu <teawater@gmail.com>
Date: Sun, 20 Jun 2010 06:34:00 -0000
Message-ID: <AANLkTil03ri3_IXkpCGVEHZMXs7UjJNmGg6Sn4_DLAXq@mail.gmail.com>
Subject: Re: [RFC/RFA] enable break
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-06/txt/msg00434.txt.bz2

It's test OK on i386-linux.

Thanks,
Hui

On Sat, Jun 19, 2010 at 09:12, Michael Snyder <msnyder@vmware.com> wrote:
> I happened to notice that if you say "help disable", you get a list
> of sub-commands that includes "disable breakpoints", but if you say
> "help enable", the list of sub-commands, does NOT include "enable
> breakpoints". =A0It also doesn't tab-complete on "enable br<tab>".
>
> On investigation, I discovered that the "enable breakpoints" command
> is instantiated using "add_abbrev_prefix_cmd". =A0What the heck -- it's
> not an abbreviation. =A0This dates back to before the current cvs repo.
>
> Changing that call to "add_prefix_cmd" fixes the issues, and causes
> no regressions when tested on amd64-linux.
>
> OK to commit?
>
>
> 2010-06-18 =A0Michael Snyder =A0<msnyder@vmware.com>
>
> =A0 =A0 =A0 =A0* breakpoint.c (_initialize_breakpoint): Use add_prefix_cm=
d,
> =A0 =A0 =A0 =A0not add_abbrev_prefix_cmd, for "enable breakpoints".
>
> Index: breakpoint.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /cvs/src/src/gdb/breakpoint.c,v
> retrieving revision 1.490
> diff -u -p -r1.490 breakpoint.c
> --- breakpoint.c =A0 =A0 =A0 =A016 Jun 2010 18:30:30 -0000 =A0 =A0 =A01.4=
90
> +++ breakpoint.c =A0 =A0 =A0 =A019 Jun 2010 01:03:40 -0000
> @@ -11264,7 +11264,7 @@ With a subcommand you can enable tempora
>
> =A0 add_com_alias ("en", "enable", class_breakpoint, 1);
>
> - =A0add_abbrev_prefix_cmd ("breakpoints", class_breakpoint, enable_comma=
nd,
> _("\
> + =A0add_prefix_cmd ("breakpoints", class_breakpoint, enable_command, _("\
> =A0Enable some breakpoints.\n\
> =A0Give breakpoint numbers (separated by spaces) as arguments.\n\
> =A0This is used to cancel the effect of the \"disable\" command.\n\
>
>