[PATCH] sim: fix handling of 2nd arg to SIM_AC_OPTION_HARDWARE

[PATCH] sim: fix handling of 2nd arg to SIM_AC_OPTION_HARDWARE

[Mike Frysinger]

The 2nd arg to SIM_AC_OPTION_HARDWARE is described as "a space separated
list of devices that override the defaults" while the 3rd arg is "a space
separated list of extra target specific devices".  But the macro doesn't
seem to treat the 2nd arg this way.

Instead, it will always add the default list of devices, and only add the
extra target specific devices if the 2nd arg is not specified.  So rework
the logic slightly to handle the 2nd arg as documented.

This shouldn't affect any targets in the tree as no one passes in a non-
empty value as the 2nd arg.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

2010-12-29  Mike Frysinger  <vapier@gentoo.org>

	* aclocal.m4 (SIM_AC_OPTION_HARDWARE): Set $hardware to $2 when $2 is
	not empty, and always append $3 to $hardware.
---
 sim/common/aclocal.m4 |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/sim/common/aclocal.m4 b/sim/common/aclocal.m4
index 9a6a4c8..bda20ce 100644
--- a/sim/common/aclocal.m4
+++ b/sim/common/aclocal.m4
@@ -571,10 +571,11 @@ else
   sim_hw_p=no
 fi
 if test "[$2]"; then
-  hardware="core pal glue"
+  hardware="[$2]"
 else
-  hardware="core pal glue [$3]"
+  hardware="core pal glue"
 fi
+hardware="$hardware [$3]"
 sim_hw_cflags="-DWITH_HW=1"
 sim_hw="$hardware"
 sim_hw_objs="\$(SIM_COMMON_HW_OBJS) `echo $sim_hw | sed -e 's/\([[^ ]][[^ ]]*\)/dv-\1.o/g'`"
-- 
1.7.3.1

Re: [PATCH] sim: fix handling of 2nd arg to SIM_AC_OPTION_HARDWARE

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 679 bytes --]

On Wednesday, December 29, 2010 19:28:33 Mike Frysinger wrote:
> The 2nd arg to SIM_AC_OPTION_HARDWARE is described as "a space separated
> list of devices that override the defaults" while the 3rd arg is "a space
> separated list of extra target specific devices".  But the macro doesn't
> seem to treat the 2nd arg this way.
> 
> Instead, it will always add the default list of devices, and only add the
> extra target specific devices if the 2nd arg is not specified.  So rework
> the logic slightly to handle the 2nd arg as documented.
> 
> This shouldn't affect any targets in the tree as no one passes in a non-
> empty value as the 2nd arg.

ping ...
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] sim: fix handling of 2nd arg to SIM_AC_OPTION_HARDWARE

[Doug Evans]

On Sat, Jan 8, 2011 at 7:51 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Wednesday, December 29, 2010 19:28:33 Mike Frysinger wrote:
>> The 2nd arg to SIM_AC_OPTION_HARDWARE is described as "a space separated
>> list of devices that override the defaults" while the 3rd arg is "a space
>> separated list of extra target specific devices".  But the macro doesn't
>> seem to treat the 2nd arg this way.
>>
>> Instead, it will always add the default list of devices, and only add the
>> extra target specific devices if the 2nd arg is not specified.  So rework
>> the logic slightly to handle the 2nd arg as documented.
>>
>> This shouldn't affect any targets in the tree as no one passes in a non-
>> empty value as the 2nd arg.
>
> ping ...
> -mike
>

Hi.  This is ok.

Re: [PATCH] sim: fix handling of 2nd arg to SIM_AC_OPTION_HARDWARE

[Mike Frysinger]

On Mon, Jan 10, 2011 at 1:07 PM, Doug Evans wrote:
> On Sat, Jan 8, 2011 at 7:51 PM, Mike Frysinger wrote:
>> On Wednesday, December 29, 2010 19:28:33 Mike Frysinger wrote:
>>> The 2nd arg to SIM_AC_OPTION_HARDWARE is described as "a space separated
>>> list of devices that override the defaults" while the 3rd arg is "a space
>>> separated list of extra target specific devices".  But the macro doesn't
>>> seem to treat the 2nd arg this way.
>>>
>>> Instead, it will always add the default list of devices, and only add the
>>> extra target specific devices if the 2nd arg is not specified.  So rework
>>> the logic slightly to handle the 2nd arg as documented.
>>>
>>> This shouldn't affect any targets in the tree as no one passes in a non-
>>> empty value as the 2nd arg.
>>
>> ping ...
>
> Hi.  This is ok.

committed then, thanks !
-mike