From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4888 invoked by alias); 10 Jan 2011 18:07:55 -0000 Received: (qmail 4880 invoked by uid 22791); 10 Jan 2011 18:07:54 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Jan 2011 18:07:49 +0000 Received: from hpaq5.eem.corp.google.com (hpaq5.eem.corp.google.com [172.25.149.5]) by smtp-out.google.com with ESMTP id p0AI7lr4029890 for ; Mon, 10 Jan 2011 10:07:48 -0800 Received: from qwj8 (qwj8.prod.google.com [10.241.195.72]) by hpaq5.eem.corp.google.com with ESMTP id p0AI75Dj001833 for ; Mon, 10 Jan 2011 10:07:46 -0800 Received: by qwj8 with SMTP id 8so20119332qwj.29 for ; Mon, 10 Jan 2011 10:07:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.224.28.133 with SMTP id m5mr26969607qac.314.1294682865856; Mon, 10 Jan 2011 10:07:45 -0800 (PST) Received: by 10.220.118.80 with HTTP; Mon, 10 Jan 2011 10:07:45 -0800 (PST) In-Reply-To: <201101082251.41469.vapier@gentoo.org> References: <1293668913-9172-1-git-send-email-vapier@gentoo.org> <201101082251.41469.vapier@gentoo.org> Date: Mon, 10 Jan 2011 18:07:00 -0000 Message-ID: Subject: Re: [PATCH] sim: fix handling of 2nd arg to SIM_AC_OPTION_HARDWARE From: Doug Evans To: Mike Frysinger Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00197.txt.bz2 On Sat, Jan 8, 2011 at 7:51 PM, Mike Frysinger wrote: > On Wednesday, December 29, 2010 19:28:33 Mike Frysinger wrote: >> The 2nd arg to SIM_AC_OPTION_HARDWARE is described as "a space separated >> list of devices that override the defaults" while the 3rd arg is "a space >> separated list of extra target specific devices". =A0But the macro doesn= 't >> seem to treat the 2nd arg this way. >> >> Instead, it will always add the default list of devices, and only add the >> extra target specific devices if the 2nd arg is not specified. =A0So rew= ork >> the logic slightly to handle the 2nd arg as documented. >> >> This shouldn't affect any targets in the tree as no one passes in a non- >> empty value as the 2nd arg. > > ping ... > -mike > Hi. This is ok.