From: Mike Frysinger <vapier@gentoo.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH] sim: fix handling of 2nd arg to SIM_AC_OPTION_HARDWARE
Date: Mon, 10 Jan 2011 21:54:00 -0000 [thread overview]
Message-ID: <AANLkTi=A-csh0Cy955A-S55GO+gQcsNq-2Hs56Gjvfnj@mail.gmail.com> (raw)
In-Reply-To: <AANLkTinog9duH6H2tLDfWumpuqOqd-LKTPf_TAsbJNxF@mail.gmail.com>
On Mon, Jan 10, 2011 at 1:07 PM, Doug Evans wrote:
> On Sat, Jan 8, 2011 at 7:51 PM, Mike Frysinger wrote:
>> On Wednesday, December 29, 2010 19:28:33 Mike Frysinger wrote:
>>> The 2nd arg to SIM_AC_OPTION_HARDWARE is described as "a space separated
>>> list of devices that override the defaults" while the 3rd arg is "a space
>>> separated list of extra target specific devices". But the macro doesn't
>>> seem to treat the 2nd arg this way.
>>>
>>> Instead, it will always add the default list of devices, and only add the
>>> extra target specific devices if the 2nd arg is not specified. So rework
>>> the logic slightly to handle the 2nd arg as documented.
>>>
>>> This shouldn't affect any targets in the tree as no one passes in a non-
>>> empty value as the 2nd arg.
>>
>> ping ...
>
> Hi. This is ok.
committed then, thanks !
-mike
prev parent reply other threads:[~2011-01-10 21:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 3:19 Mike Frysinger
2011-01-09 3:51 ` Mike Frysinger
2011-01-10 18:07 ` Doug Evans
2011-01-10 21:54 ` Mike Frysinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=A-csh0Cy955A-S55GO+gQcsNq-2Hs56Gjvfnj@mail.gmail.com' \
--to=vapier@gentoo.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=toolchain-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox