From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15459 invoked by alias); 10 Jan 2011 21:54:45 -0000 Received: (qmail 15451 invoked by uid 22791); 10 Jan 2011 21:54:44 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 10 Jan 2011 21:54:40 +0000 Received: by mail-fx0-f41.google.com with SMTP id 12so12786823fxm.0 for ; Mon, 10 Jan 2011 13:54:40 -0800 (PST) Received: by 10.223.95.202 with SMTP id e10mr5926800fan.32.1294696480208; Mon, 10 Jan 2011 13:54:40 -0800 (PST) MIME-Version: 1.0 Received: by 10.223.74.137 with HTTP; Mon, 10 Jan 2011 13:54:19 -0800 (PST) In-Reply-To: References: <1293668913-9172-1-git-send-email-vapier@gentoo.org> <201101082251.41469.vapier@gentoo.org> From: Mike Frysinger Date: Mon, 10 Jan 2011 21:54:00 -0000 Message-ID: Subject: Re: [PATCH] sim: fix handling of 2nd arg to SIM_AC_OPTION_HARDWARE To: Doug Evans Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00206.txt.bz2 On Mon, Jan 10, 2011 at 1:07 PM, Doug Evans wrote: > On Sat, Jan 8, 2011 at 7:51 PM, Mike Frysinger wrote: >> On Wednesday, December 29, 2010 19:28:33 Mike Frysinger wrote: >>> The 2nd arg to SIM_AC_OPTION_HARDWARE is described as "a space separated >>> list of devices that override the defaults" while the 3rd arg is "a spa= ce >>> separated list of extra target specific devices". =A0But the macro does= n't >>> seem to treat the 2nd arg this way. >>> >>> Instead, it will always add the default list of devices, and only add t= he >>> extra target specific devices if the 2nd arg is not specified. =A0So re= work >>> the logic slightly to handle the 2nd arg as documented. >>> >>> This shouldn't affect any targets in the tree as no one passes in a non- >>> empty value as the 2nd arg. >> >> ping ... > > Hi. =A0This is ok. committed then, thanks ! -mike