From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Pierre Marsais <pierre.marsais@lse.epita.fr>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH v4 2/3] Do not mistreat instructions as cmpxchg8b
Date: Thu, 11 Oct 2018 11:56:00 -0000 [thread overview]
Message-ID: <A78C989F6D9628469189715575E55B236B364CC9@IRSMSX104.ger.corp.intel.com> (raw)
In-Reply-To: <20181006001539.32414-2-pierre.marsais@lse.epita.fr>
Hello Pierre,
> + switch (ir.reg) {
> + case 1: /* cmpxchg8b */
> + if (ir.mod == 3)
> + {
> + ir.addr -= 2;
> + opcode = opcode << 8 | ir.modrm;
> + goto no_support;
> + }
We'd also need to check that neither 66 nor f3 prefixes are used.
> + case 6: /* rdrand */
> + case 7: /* rdseed */
> + if (ir.mod != 3)
> + {
> + /* We don't handle this particular instruction yet. */
> + ir.addr -= 2;
> + opcode = opcode << 8 | ir.modrm;
> + goto no_support;
> + }
We'd also need to check that f3 prefix is not used.
Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Christian Lamprechter
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
prev parent reply other threads:[~2018-10-11 11:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 0:38 [PATCH] Add support for recording xsave x86 instruction Pierre Marsais
2018-09-27 8:45 ` Metzger, Markus T
2018-10-01 0:25 ` Pierre Marsais
2018-10-01 6:58 ` Metzger, Markus T
2018-10-03 0:05 ` Pierre Marsais
2018-10-01 0:29 ` [PATCH v2] " Pierre Marsais
2018-10-02 23:55 ` [PATCH v3] " Pierre Marsais
[not found] ` <CAMe9rOqTeGBckegskZLKxJJL-aexTiorLTEbL2kps_KjJs20Rg@mail.gmail.com>
2018-10-06 0:20 ` Pierre Marsais
2018-10-06 0:16 ` [PATCH v4 1/3] " Pierre Marsais
2018-10-06 0:16 ` [PATCH v4 3/3] Add support for recording xsavec " Pierre Marsais
2018-10-06 0:16 ` [PATCH v4 2/3] Do not mistreat instructions as cmpxchg8b Pierre Marsais
2018-10-11 11:56 ` Metzger, Markus T [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A78C989F6D9628469189715575E55B236B364CC9@IRSMSX104.ger.corp.intel.com \
--to=markus.t.metzger@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.marsais@lse.epita.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox