From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55567 invoked by alias); 11 Oct 2018 11:56:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51376 invoked by uid 89); 11 Oct 2018 11:56:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_20,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Commercial, Managing, Directors, H*f:sk:2018092 X-HELO: mga04.intel.com Received: from mga04.intel.com (HELO mga04.intel.com) (192.55.52.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Oct 2018 11:56:17 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2018 04:56:16 -0700 Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by fmsmga001.fm.intel.com with ESMTP; 11 Oct 2018 04:56:08 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.213]) by irsmsx110.ger.corp.intel.com ([169.254.15.182]) with mapi id 14.03.0319.002; Thu, 11 Oct 2018 12:56:07 +0100 From: "Metzger, Markus T" To: Pierre Marsais , "gdb-patches@sourceware.org" Subject: RE: [PATCH v4 2/3] Do not mistreat instructions as cmpxchg8b Date: Thu, 11 Oct 2018 11:56:00 -0000 Message-ID: References: <20180921003827.1525-1-pierre.marsais@lse.epita.fr> <20181006001539.32414-1-pierre.marsais@lse.epita.fr> <20181006001539.32414-2-pierre.marsais@lse.epita.fr> In-Reply-To: <20181006001539.32414-2-pierre.marsais@lse.epita.fr> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00275.txt.bz2 Hello Pierre, > + switch (ir.reg) { > + case 1: /* cmpxchg8b */ > + if (ir.mod =3D=3D 3) > + { > + ir.addr -=3D 2; > + opcode =3D opcode << 8 | ir.modrm; > + goto no_support; > + } We'd also need to check that neither 66 nor f3 prefixes are used. > + case 6: /* rdrand */ > + case 7: /* rdseed */ > + if (ir.mod !=3D 3) > + { > + /* We don't handle this particular instruction yet. */ > + ir.addr -=3D 2; > + opcode =3D opcode << 8 | ir.modrm; > + goto no_support; > + } We'd also need to check that f3 prefix is not used. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Christian Lamprechter Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928